Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement note rule CPMR0067 - notSilent tag is being used #36

Open
2 tasks done
Tracked by #30
AdmiringWorm opened this issue Jan 28, 2024 · 0 comments · May be fixed by #54
Open
2 tasks done
Tracked by #30

Implement note rule CPMR0067 - notSilent tag is being used #36

AdmiringWorm opened this issue Jan 28, 2024 · 0 comments · May be fixed by #54
Assignees
@AdmiringWorm
Labels
3 - Review Code has been added, and is available for review as a pull request Improvement Issues that enhances existing functionality, or adds new features
Milestone
0.2.0

Comments

@AdmiringWorm
Copy link
Member

Checklist

  • I have verified this is the correct repository for opening this issue.
  • I have verified no other issues exist related to my request.

Is Your Feature Request Related To A Problem? Please describe.

No response

Describe The Solution. Why is it needed?

We should implement the note rule available in Package Validator that flags the tag notSilent when it is present in the nuspec file.
This tag should only be used if the package is not completely silent (ie, shows a progressbar, is automated using AutoHotkey, etc).

The validation rule should flag this use no matter what the casing used is.

Additional Context

Rule Documentation: https://ch0.co/rules/cpmr0067

The documentation is currently stubbed out, and is required to be filled out as well in the docs repository

Related Issues

No response
@AdmiringWorm AdmiringWorm added Improvement Issues that enhances existing functionality, or adds new features 0 - Backlog Issue is accepted, but is not ready to be worked on or not in current sprint labels Jan 28, 2024
@AdmiringWorm AdmiringWorm added this to the 0.2.0 milestone Jan 28, 2024
@AdmiringWorm AdmiringWorm mentioned this issue Jan 28, 2024
Open
8 tasks
@AdmiringWorm AdmiringWorm added 1 - Ready Issue is accepted, milestone added and are ready to be worked on and removed 0 - Backlog Issue is accepted, but is not ready to be worked on or not in current sprint labels Apr 25, 2024
@AdmiringWorm AdmiringWorm self-assigned this Jul 26, 2024
@AdmiringWorm AdmiringWorm added 2 - Working A user or team member has started working on the issue and removed 1 - Ready Issue is accepted, milestone added and are ready to be worked on labels Jul 26, 2024
AdmiringWorm added a commit to AdmiringWorm/chocolatey-community-validation that referenced this issue Nov 28, 2024
@AdmiringWorm
(chocolatey-community#36) Implement note rule CPMR0067
b069215 
This implements a new note rule for CPMR0067 that checks if the tag
`notSilent` has been used or not.
@AdmiringWorm AdmiringWorm linked a pull request Nov 28, 2024 that will close this issue
Open
10 tasks
AdmiringWorm added a commit to AdmiringWorm/chocolatey-community-validation that referenced this issue Nov 28, 2024
@AdmiringWorm
(chocolatey-community#36) Implement note rule CPMR0067
075064c 
This implements a new note rule for CPMR0067 that checks if the tag
`notSilent` has been used or not.
@AdmiringWorm AdmiringWorm added 3 - Review Code has been added, and is available for review as a pull request and removed 2 - Working A user or team member has started working on the issue labels Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdmiringWorm AdmiringWorm

Labels
3 - Review Code has been added, and is available for review as a pull request Improvement Issues that enhances existing functionality, or adds new features
Projects
None yet
Milestone
0.2.0
Development

Successfully merging a pull request may close this issue.

(#36) Add rule for validating usage of notSilent tag AdmiringWorm/chocolatey-community-validation
1 participant
@AdmiringWorm