(#34) Implement note rule CPMR0061 - Id Contains "." #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This implements the note rule CPMR0061 that verifies whether a package
uses a dot in its identifier, which is not recommended to do unless
absolutely necessary.
This implementation is more comprehensive than what is implemented in
package validator, where package validator will have false negatives
that this implementation will properly flag.
Motivation and Context
We want to implement as many rules as we can that is currently handled by package validator.
Testing
THis is mostly covered by unit tests, but can be manually verified by
.
in its identifier.choco pack
on the created nuspec file.CPMR0061
is shown..install
, but keep the other.
in its identifier.choco pack
on the nuspec file again.CPMR0061
is shown..
in the identifier, but keep.install
.choco pack
on the nuspec file.CPMR0061
is no longer displayed.Operating Systems Testing
Change Types Made
Change Checklist
Related Issue
Fixes #34