(#38) Add rule for validating ID length #53
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This implements the note rule CPMR0069, that verifies that the length of
the package identifier is not longer than 20 characters without a dash
between the words.
This implementation is more restrict than what is currently implemented
on Package Validator as it will also consider packages that have certain
extension, just by removing this extension first and it will also verify
that any section between dashes is not longer than 20 characters.
Motivation and Context
To implement rules already present on Package Validator.
Testing
choco pack
on the created nuspec file.CPMR0069
is flagged..extension
to the identifier (total length should be 29).choco pack
on the updated nuspec file.CPMR0069
is NOT flagged..extension
(total identifier length should be 30).choco pack
on the updated nuspec file.CPMR0069
is flagged.-
) where all words are less than 20 characters.choco pack
on the updated nuspec file.CPMR0069
is NOT flagged.choco pack
on the updated nuspec file.CPMR0069
is flagged.Operating Systems Testing
Change Types Made
Change Checklist
Related Issue
Fixes #38