Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#37) Implement note rule CPMR0068 #55

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

AdmiringWorm
Copy link
Member

Description Of Changes

This implements the note rule CPMR0068 that verifies whether the owners
field matches the authors field or not.

This is equivalent to what is implemented in Package Validator, and
should be enhanced in the future.

Motivation and Context

To include as many rules as we can that is implemented by Package Validator.

Testing

  1. Create a nuspec file.
  2. Update the tags element to contain the tag notSilent
  3. Run choco pack on the created nuspec file.
  4. Verify the rule CPMR0068 is flagged.
  5. Repeat previous steps with different letter casing.

Operating Systems Testing

  • Windows 10

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v3 compatibility checked?

Related Issue

Fixes #37

This implements the note rule CPMR0068 that verifies whether the owners
field matches the authors field or not.

This is equivalent to what is implemented in Package Validator, and
should be enhanced in the future.
@AdmiringWorm AdmiringWorm self-assigned this Nov 28, 2024
@AdmiringWorm
Copy link
Member Author

AdmiringWorm commented Nov 28, 2024

It is expected that the GHA build will fail, verify with the internal build instead.

EDIT:

PR #56 should be merged before this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement note rule CPMR0068 - Author Does Not Match Maintainer
1 participant