Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(1password) Add support for 1password v8.x (fixes #1773) #2108

Closed
wants to merge 4 commits into from
Closed

(1password) Add support for 1password v8.x (fixes #1773) #2108

wants to merge 4 commits into from

Conversation

egerlach
Copy link

@egerlach egerlach commented Jan 7, 2023 •
edited
Loading

Description

  • 1password v8 doesn't have the same URL redirect available to it. Instead, parse the HTML page from the update server to find the links to the downloads.
  • Also convert v4 and v7 to this method of getting new versions.
  • 1password v7 is maintained in a separate stream, confusingly named OPW6 because major version 7 is kept in the same update stream as v6 on the AgileBits update server.
  • Beta streams for all three major versions are included. In beta streams for v4 and v8, the fourth version component is used for the build number, which is included in the upstream version.
  • 1password.json has been carefully updated so that the most recent item in the stream that is also available in the community repo is represented. This ensures that correct new versions are built and existing versions are skipped and correctly recorded in this file.
  • Nightly versions are silently discarded

Motivation and Context

Fixes #1773

How Has this Been Tested?

  • Ran update.ps1 to generate new packages
  • Installed each of the packages in chocolatey-test-environment (which was an adventure in and of itself)
  • Tested resulting packages on a Windows 10 VM and a Windows 10 desktop (mine)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Migrated package (a package has been migrated from another repository)

Checklist:

  • My code follows the code style of this repository.
  • My change requires a change to documentation (this usually means the notes in the description of a package).
  • I have updated the documentation accordingly (this usually means the notes in the description of a package).
  • I have updated the package description and it is less than 4000 characters.
  • All files are up to date with the latest Contributing Guidelines
  • The added/modified package passed install/uninstall in the chocolatey test environment.
  • The changes only affect a single package (not including meta package).

@egerlach
(1password) Add support for 1password v8.x
a5a9e89 
* 1password v8 doesn't have the same URL redirect available to it. Instead,
  parse the HTML page from the update server to find the links to the
  downloads.
* Also convert v4 and v7 to this method of getting new versions.
* 1password v7 is maintained in a separate stream, confusingly named
  OPW6 because major version 7 is kept in the same update stream as v6
  on the AgileBits update server.
* Beta streams for all three major versions are included. In beta
  streams for v4 and v8, the fourth version component is used for the
  build number, which is included in the upstream version.
* 1password.json has been carefully updated so that the most recent item
  in the stream that is also available in the community repo is
  represented. This ensures that correct new versions are built and
  existing versions are skipped and correctly recorded in this file.
* Nightly versions are silently discarded
@AppVeyorBot
Copy link

❌ Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look.

@egerlach
(1password) Fix uninstaller for 8.x
84f80d8 
The 1password uninstaller call changed from v7 to v8. This fixes the
uninstall script for versions 4, 7, and 8.
@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

@egerlach
Copy link
Author

Updated comments on testing. While I was able to test all of the 1password 4.x and 1password 7.x packages on chocolatey-test-environment, I could not do so with 1password 8.x because Windows Server 2012 is no longer supported. Instead I tested the packages on a Windows 10 VM and a Windows 10 desktop.

@pauby
Copy link
Member

pauby commented Jan 28, 2023

The new Chocolatey Test Environment is based on Windows Server 2019.

@egerlach
Move checksum calculation from automatic to manual
270e379 
I do my development on Linux so this avoids any issues with differences
between my environment and Windows during development.
@egerlach
Add error message for incompatible OS Versions
31b75ae 
1password 8+ isn't compatible with Windows desktop <10 or Windows
Server <2016.
@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

@egerlach
Copy link
Author

The new Chocolatey Test Environment is based on Windows Server 2019.

Ah, I missed that. Will adapt that to my environment and then I'll re-test.

@AdmiringWorm
Copy link
Member

@egerlach I recommend holding off on making any changes to this pull request for now.

We have had some internal discussions about whether we should keep maintaining this package in this repository, create an RFM request to give it away to new maintainers or ask the developers of 1password if they are interested in taking over the maintenance.

I'll move this PR into a draft for now, but it may be closed once a decision and a result have been achieved.

@AdmiringWorm AdmiringWorm marked this pull request as draft February 3, 2023 11:47
@JPRuskin
Copy link
Contributor

JPRuskin commented Feb 3, 2023

I've reached out to 1Password about this.

@egerlach
Copy link
Author

egerlach commented Feb 3, 2023

Thanks @AdmiringWorm and @JPRuskin for the clarity of your status. It's refreshing not to be in limbo on a PR :)

I've posted my thoughts in the discussion as they're off-topic for the PR.

@pauby
Copy link
Member

pauby commented Jul 22, 2023

@AdmiringWorm @JPRuskin @egerlach I'm keen to move this PR forward but we should also consider closing it if there is no movement.

@JPRuskin any update from 1Password?

@imiddleton1
Copy link

Has anyone tried using this link? It's always the latest version. It was sent to me by 1password support:

https://downloads.1password.com/win/1PasswordSetup-latest.msi

@compuguy
Copy link

Any updates on this?

@pauby
Copy link
Member

pauby commented Nov 28, 2023 •
edited
Loading

As there has been no movement on this, I'm going to close it. We can always reopen it again later.

@egerlach thanks for your contribution. Set do appreciate it despite the discussions around the PR having stalled. Apologies for taking so long.

@pauby pauby closed this Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Invalid / Not Issue / No repro / Not Implementing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(1password) Update to Version 8.x
7 participants
@egerlach @AppVeyorBot @pauby @AdmiringWorm @JPRuskin @imiddleton1 @compuguy