(musescore) Cleanup update.ps1 links

[umol-unibas]

Description

The changed hard-coded link is not necessary in the old format and the way it is worded suggests that the download location is sufficient. There is already a valid download-link generated and pushed to the VERIFICATION.txt, so there is no need for a second one.

Motivation and Context

In the VERIFICATION.txt were two msi-links included. As the first one is not necessary and suggests that the download location is sufficient, it would be great if it could be changed, because of some automations we are using.

How Has this Been Tested?

This change does not harm or interrupt the update-module and its process at all as the link is only there for informational purpose.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Migrated package (a package has been migrated from another repository)

Checklist:

• My code follows the code style of this repository.
• My change requires a change to documentation (this usually means the notes in the description of a package).
• I have updated the documentation accordingly (this usually means the notes in the description of a package).
• I have updated the package description and it is less than 4000 characters.
• All files are up to date with the latest Contributing Guidelines
• The added/modified package passed install/uninstall in the chocolatey test environment.
• The changes only affect a single package (not including meta package).

[AppVeyorBot]

❌ Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look.

[stokes-unibas]

Looks good to me, tested and works

[AppVeyorBot]

✅ Package verification completed without issues. PR is now pending human review

[AppVeyorBot]

✅ Package verification completed without issues. PR is now pending human review

[pauby]

This latest change is being made in the wrong place. If we are going to hard code the link we should just update the VERIFICATION.txt file directly and remove the updating of 'location on' that is done here. There isn't any point in automatically updating a file with the same text each time if it's not going to change. And if it does change then we need to update the update script anyway so it's no more hassle updating the VERIFICATION.txt file directly.

@umol-unibas Does that make sense?

[AppVeyorBot]

❌ Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look.

[umol-unibas]

You are right @pauby. There is no need in updating the update.ps1 as it works fine - i'm not sure why i changed that. According to your message and our discussion i reverted the update-script and changed the VERIFICATION.txt. That was my idea was in the first place for this PR.

Reasons for the changes in the VERIFICATION.txt: the hard-coded link ("https://musescore.org/en/download/musescore.msi ") is

• not necessary as it is a duplication
• it could be puzzling because of the other link
• it has no meaning

[AppVeyorBot]

❌ Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look.

[AppVeyorBot]

✅ Package verification completed without issues. PR is now pending human review

[AdmiringWorm]

LGTM

[umol-unibas]

Thanks!