Replace unmaintained apache-httpd project with new one
#2467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also download expected checksums from ApacheLounge instead of calculating them ourselves Tested automatic upgrade from 2.4.58 to 2.4.59
httpd.exe assumes the service name is Apache2.4, so we should use that by default. If you don't want the install script to break your configuration, there is now an option to skip it, but we also need to be able to skip starting the service in that case.
|
✅ Package verification completed without issues. PR is now pending human review |
JPRuskin
reviewed
Jun 13, 2024
The apache installer was outputting to the error stream. This can impact users who have failOnStandardError enabled, so we prefer to adjust it where found. This change captures anything output by the installer on the error stream (2) and puts it on the standard success/output stream (1).
JPRuskin
reviewed
Jul 25, 2024
| setConfiguration = if ($pp.SkipConfiguration) { $false } else { $true } | ||
| } | ||
|
|
||
| if ($arguements.setConfiguration -and -not (Assert-TcpPortIsOpen $arguments.port)) { |
There was a problem hiding this comment.
Suggested change
| if ($arguements.setConfiguration -and -not (Assert-TcpPortIsOpen $arguments.port)) { | |
| if ($arguments.setConfiguration -and -not (Assert-TcpPortIsOpen $arguments.port)) { |
|
✅ Package verification completed without issues. PR is now pending human review |
JPRuskin
reviewed
Jul 25, 2024
|
|
||
| Start-Service $arguments.serviceName | ||
| if ($arguements.StartService) { |
There was a problem hiding this comment.
Suggested change
| if ($arguements.StartService) { | |
| if ($arguments.StartService) { |
JPRuskin
reviewed
Jul 25, 2024
Comment on lines
+175
to
176
| Write-Warning "This command is expected to write debugging output. Chocolately treats that as an error. Please read the error text to confirm whether service installation succeed." | ||
| & $apachePaths.BinPath -k uninstall -n "$($arguments.serviceName)" |
There was a problem hiding this comment.
Suggested change
| Write-Warning "This command is expected to write debugging output. Chocolately treats that as an error. Please read the error text to confirm whether service installation succeed." | |
| & $apachePaths.BinPath -k uninstall -n "$($arguments.serviceName)" | |
| # This command outputs to the error stream. 2>&1 redirects that to output. | |
| & $apachePaths.BinPath -k uninstall -n "$($arguments.serviceName)" 2>&1 |
Replicate the pattern from the other call similar to this.
|
Dear contributor, As this PR seems to have been inactive for 30 days after changes or additional information |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(apache-httpd) (apachelounge-httpd) Replace unmaintained Apache HTTPD package
Description
Create a new package based on the ApacheLounge HTTPD build to replace the Apache Haus build which is no longer maintained. The package name has been changed to reflect that the build has changed, but they are supposed to be binary-compatible.
Motivation and Context
The old package is no longer updated.
Related discussion: https://github.com/orgs/chocolatey-community/discussions/2216
How Has this Been Tested?
Installed manually on Windows 10 and Windows 11.
I was not able to get the
chocolatey-test-environmentrunning on my machine - possibly a Vagrant issueChecklist: