Adds Argument Completers To Update_All Script #2498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QOL improvement: being able to tab complete packages in the arguments for the update_all script for use when developing or testing packages. Name tab completes from the list of existing packages, ForcedPackages tab completes from existing packages _prioritising those already in Name_.
|
✅ Package verification completed without issues. PR is now pending human review |
|
I think this should be added to the packages template repository we have before it is added here. Can you create an issue about it over at https://github.com/chocolatey-community/chocolatey-packages-template (and probably a PR)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running the
Update_All.ps1script,-Namecan now tab-complete from the list of existing packages in the specified root-directory, and ForcedPackages can tab complete from existing packages prioritising those already in Name.Definitely up for chatting if this actually fits other users, here, but I think it's a nice change to have - and it shouldn't break anyone else's workflow.
Motivation and Context
When testing PRs or branches, I frequently run Update_All with specific name or forced packages.
As a quality of life improvement, being able to tab complete packages in the arguments for the update_all script for use when developing or testing packages is pretty neat.
2024-07-03_14-05-26.mp4
How Has this Been Tested?
Tested locally on PowerShell 5.1.
Types of changes
[ ] Bug fix (non-breaking change which fixes an issue)[ ] Breaking change (fix or feature that would cause existing functionality to change)[ ] Migrated package (a package has been migrated from another repository)Checklist:
[ ] My change requires a change to documentation (this usually means the notes in the description of a package).[ ] I have updated the documentation accordingly (this usually means the notes in the description of a package).[ ] I have updated the package description and it is less than 4000 characters.[ ] All files are up to date with the latest Contributing Guidelines[ ] The added/modified package passed install/uninstall in the Chocolatey Test Environment(https://github.com/chocolatey-community/chocolatey-test-environment/). Note that we don't support the use of any other environment.[ ] The changes only affect a single package (not including meta package).