Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(graphviz) fix typo preventing uninstallation #2513

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

bluebird75
Copy link
Contributor

@bluebird75 bluebird75 commented Aug 7, 2024

Fixes #2512

Description

Typo in the powershell script, the code made no sense and would crash.

Motivation and Context

Uninstallation was not possible due to crash of unintall powershel script

How Has this Been Tested?

The fixed script was run successfully and uninstallation succeeded

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Migrated package (a package has been migrated from another repository)

Checklist:

  • My code follows the code style of this repository.
  • My change requires a change to documentation (this usually means the notes in the description of a package).
  • I have updated the documentation accordingly (this usually means the notes in the description of a package).
  • I have updated the package description and it is less than 4000 characters.
  • All files are up to date with the latest Contributing Guidelines
  • The added/modified package passed install/uninstall in the Chocolatey Test Environment(https://github.com/chocolatey-community/chocolatey-test-environment/). Note that we don't support the use of any other environment.
  • [ x] The changes only affect a single package (not including meta package).

@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

The uninstallation was working but not silent, the script was missing its puropose.
@bluebird75
Copy link
Contributor Author

The error was also preventing the removal of shims

@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

Copy link
Member

@AdmiringWorm AdmiringWorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdmiringWorm AdmiringWorm merged commit 8095a2c into chocolatey-community:master Oct 25, 2024
1 check passed
@AdmiringWorm
Copy link
Member

@bluebird75 your changes have been merged. Thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graphiviz uninstallation does not work
3 participants