Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-2334) (notepadplusplus.commandline)(notepadplusplus.install) Stop relaunch as Admin #2566

Merged

Conversation

pauby
Copy link
Member

@pauby pauby commented Nov 8, 2024

NOTE: This will require pushing a package fix version.

Description

Removes relaunching Notepad++ as part of the package.

Motivation and Context

This fixes #2334: the problem that launching the application does so in the context of the elevated Chocolatey CLI session.

How Has this Been Tested?

This replaces the Write-Host text and removes the Start-Process that launched the application in the elevated context.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Migrated package (a package has been migrated from another repository)

Checklist:

  • My code follows the code style of this repository.
  • My change requires a change to documentation (this usually means the notes in the description of a package).
  • I have updated the documentation accordingly (this usually means the notes in the description of a package).
  • I have updated the package description and it is less than 4000 characters.
  • All files are up to date with the latest Contributing Guidelines
  • The added/modified package passed install/uninstall in the Chocolatey Test Environment(https://github.com/chocolatey-community/chocolatey-test-environment/). Note that we don't support the use of any other environment.
  • The changes only affect a single package (not including meta package).

@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

Copy link
Member

@AdmiringWorm AdmiringWorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we eventually should look at how we can launch the application in non-admin mode, but for now I think it is fine.

So, LGTM.

@AdmiringWorm AdmiringWorm merged commit 72600fd into chocolatey-community:master Nov 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants