Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(mkdocs) Migrate MkDocs Package #469

Merged
merged 2 commits into from
Dec 12, 2016

Conversation

pascalberger
Copy link
Member

This PR is to move the MkDocs package from https://github.com/BBTSoftwareAG/chocolatey-packages to the Core Team Packages.

I invited the Chocolatey user as a maintainer.

<tags>mkdocs markdown documentation foss cross-platform cli</tags>
<releaseNotes>http://www.mkdocs.org/about/release-notes/</releaseNotes>
<dependencies>
<dependency id="Python" version="2.6" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MkDocs supports Python versions 2.6, 2.7, 3.3, 3.4, 3.5 and pypy.
I would use v3 honestly as it supports unicode.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They'll drop support for Python 2.6 in 1.0: mkdocs/mkdocs#165. But IMHO as long as Python 2.6 is still supported this should be reflected in the Chocolatey Package. Since this is a minimum constraint it's up to the user to decide which of the supported Python versions he want's to use.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it support unicode with 2.6 then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I never had it running with 2.6

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just use versionless dependency and users will continue with whatever they currently have.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was actually my idea, but also to make sure that at least Python 2.6 is installed, which is the minimum required version by MkDocs. If we completely remove the version user could also have Python 2.5 installed. On the other hand the constraint above still would be fulfilled if the user has Python 3.x installed. Or am I missing something?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. I mistaken your dependency to that of python2 package.

@majkinetor majkinetor merged commit 45662b4 into chocolatey-community:master Dec 12, 2016
@majkinetor
Copy link
Contributor

Don't forget to remove ketarin job.

@pascalberger pascalberger deleted the mkdocs branch December 12, 2016 20:11
@gep13
Copy link
Member

gep13 commented Dec 13, 2016

Chocolatey user has been added to the package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants