Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Server 2016 testing environment #23

Open
wants to merge 31 commits into
base: master
Choose a base branch
from

Conversation

basictheprogram
Copy link

Windows Server 2016 testing environment with updated tool chain.

Copy link
Contributor

@ferventcoder ferventcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments for review

if (Get-Command "choco.exe" -ErrorAction SilentlyContinue)
{
"7zip", "bitvise-ssh-server", "git", "notepadplusplus" | ForEach-Object -Process {choco install $_}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for these to be here. They were pre-installed on the older system

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://github.com/chocolatey/chocolatey-test-environment/issues the tool chain is very old and I'd like to have the tools upgraded.

We can fork the packer project and add the tools in packer but this keeps the design clean and installs current tools in this project.

See my comments about using chocolatey to install the tools because I view the test environment as testing chocolatey packages and not chocolatey itself it's ok(?) to use chocolate to install the latest version of tools?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments about using chocolatey to install the tools because I view the test environment as testing chocolatey packages and not chocolatey itself it's ok(?) to use chocolate to install the latest version of tools?

That's likely fine.

Vagrantfile Show resolved Hide resolved
@@ -14,7 +14,7 @@ end
Vagrant.configure("2") do |config|
# This setting will download the atlas box at
# https://atlas.hashicorp.com/ferventcoder/boxes/win2012r2-x64-nocm
config.vm.box = "ferventcoder/win2012r2-x64-nocm"
config.vm.box = "BasicTheProgram/windows_2016"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure we'd convert to another box, apologies. We would need to really review it for safety and security, as this test environment is used in many environments.

And do you have vmware_fusion, hyper-v, and virtualbox versions?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not have fusion, or hyper-v versions, but packer has the ability to build all of the above with a pretty simple command line evocation.

See my comments in the google group about having git branches for each version of windows or having multiple versions of Windows supported in the VagrantFile.

I have the need for a Windows 2016 testing environment, thus these changes. I don't want to deprecated or diminish the Server 2012 R2 stuff, ideally supporting multiple test environments is the goal. Just need guidance from you on how to do that.

And, ideally, you'd take over the official config.vm.box stuff. Probably build via packer to make it easier for people to contribute to the test environment?

config.vm.provision :shell, :path => "shell/InstallNet4.ps1", privileged: false
config.vm.provision :shell, :path => "shell/InstallChocolatey.ps1", privileged: false
config.vm.provision :shell, :path => "shell/NotifyGuiAppsOfEnvironmentChanges.ps1",privileged: false
config.vm.provision :shell, :path => "shell/InstallToolchain.ps1", privileged: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why non-privileged? It needs to succeed, which is highly likely to need to run with admin on the VM. Not sure I understand this change

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See hashicorp/vagrant#9138 for the ugly details. Looks like a change in Windows Server 2016 Build 14393.rs1_release.170917-1700.

Happy to change it if you know another work-around for Windows Server 2016. If you read the ticket the upstream maintainer of the packer scripts reports that this specific build of Windows Server 2016 has the problem.

So can work around it or wait(?) for Microsoft to change thing back?

basictheprogram and others added 25 commits December 22, 2017 15:09
…latey-test-environment into win2012r2-x64-nocm
Windows Server 2016

WIP chocolatey-community#31 but for
Windows Server 2016
Get the Windows Server 2016 from Vagrant Cloud
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants