Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(GH-132)(GH-131) Add context menu for *.nupkg and *.nuspec and 'choco new' in Finder window #275

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

(GH-132)(GH-131) Add context menu for *.nupkg and *.nuspec and 'choco new' in Finder window #275

wants to merge 3 commits into from

Conversation

steviecoaster
Copy link
Contributor

@steviecoaster steviecoaster commented Oct 8, 2019 •
edited
Loading

Description

Adds a right-click context menu for creating new packages when folder is selected, or pushing when a nupkg is selected.

Related Issue

#132
#131

Motivation and Context

Mostly....because I can

How Has This Been Tested?

Ran in VSCode extension debugger.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@AdmiringWorm
Copy link
Member

Please do correct me if I am wrong, but isn't there also a need to change the code itself?
Otherwise you would still be prompted to select a nupkg/nuspec file.

@steviecoaster
Copy link
Contributor Author

Please do correct me if I am wrong, but isn't there also a need to change the code itself?
Otherwise you would still be prompted to select a nupkg/nuspec file.

Yes, there is more work to be done before we merge this in, but I need to have a quick chat with Gary about those changes before proceeding.

@steviecoaster steviecoaster changed the title Feature context menu (GH-132)(GH-131) Add context menu for *.nupkg and *.nuspec and 'choco new' in Finder window Oct 9, 2019
This was linked to issues Apr 15, 2020
Add context menu for packing nuspec files #131
Open
Add context menu for pushing nupkg files #132
Open
@corbob corbob marked this pull request as draft September 5, 2024 20:59
@corbob
Copy link
Contributor

corbob commented Sep 5, 2024

Switching this to draft PR based on the previous comments regarding additional code changes needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gep13 gep13 Awaiting requested review from gep13

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add context menu for pushing nupkg files Add context menu for packing nuspec files
3 participants
@steviecoaster @AdmiringWorm @corbob