Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(GH-70) Implemented rule to validate deprecated package have dependency #164

Merged
merged 3 commits into from
Mar 9, 2019
Merged

(GH-70) Implemented rule to validate deprecated package have dependency #164

merged 3 commits into from
Mar 9, 2019

Conversation

AdmiringWorm
Copy link
Member

Description

Added validation rule to validate wether a deprecated package have a dependency or not.

Related Issue

#70

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@AdmiringWorm
Copy link
Member Author

this PR is dependent on #163 to work at all.
The validation will always fail without the other PR.

gep13
gep13 approved these changes Mar 9, 2019
View reviewed changes
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit 2ae5a3d into chocolatey-community:develop Mar 9, 2019
@gep13
Copy link
Member

gep13 commented Mar 9, 2019

@AdmiringWorm your changes have been merged, thanks for your contribution 👍

gep13 pushed a commit that referenced this pull request Mar 9, 2019
@web-flow
AppVeyor Publish: 2ae5a3d
118f35b 
Merge pull request #164 from AdmiringWorm/feature/deprecated-pkg-rule

(GH-70) Implemented rule to validate deprecated package have dependency
@AdmiringWorm AdmiringWorm deleted the feature/deprecated-pkg-rule branch March 9, 2019 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gep13 gep13 gep13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdmiringWorm @gep13