-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(GH-267) Using chocolatey.lib for local operations. #282
Conversation
/cc @ferventcoder @gep13 |
Updated chocolatey lib version. Moved OData search to chocolatey. Use Nuget's Semantic Version. Align PackageViewModel more closely with IPackage. TODO: Sorting!!!!
1c4e1d4
to
ecd29a1
Compare
@RichiCoder1 Just been looking through this, and it looks good to me! I am loving the amount of code that we can now remove 👍 I have corrected a few Code Analysis, InspectCode errors, etc, but there are still some left. They are regarding the Thanks! There is still an issue with the build that I will need to look into tomorrow, but once that and the InspectCode issues are corrected, we should be in a position to merge this into the develop branch! 😄 |
@RichiCoder1 ok, I see what the issue with the build is, I will fix that up tomorrow morning. Cheers! |
640d1cb
to
ebae4d1
Compare
Oh, that's weird! When running on AppVeyor, the errors that I am seeing locally are only warnings: Not sure why they are reacting differently, as they should be using the same configuration file. Anyway, if you are happy, I can merge this into the develop branch, and look to start a new release. Thoughts? |
I'd be ok with merging, but I don't want to release this until we've got a sufficient level of polish around things like progress messages and command execution dialogs. |
ChocolateyGUI is now using chocolatey.lib for all "local" operations. Namely list -lo, install, uninstall, upgrade, and sources. Only "remote" operations are still using the OData provider.