Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-267) Using chocolatey.lib for local operations. #282

Merged
merged 18 commits into from
Apr 18, 2016

Conversation

RichiCoder1
Copy link
Contributor

ChocolateyGUI is now using chocolatey.lib for all "local" operations. Namely list -lo, install, uninstall, upgrade, and sources. Only "remote" operations are still using the OData provider.

@RichiCoder1
Copy link
Contributor Author

/cc @ferventcoder @gep13

@RichiCoder1 RichiCoder1 mentioned this pull request Sep 25, 2015
8 tasks
@gep13 gep13 force-pushed the feature/Chocolatey_Lib branch from 1c4e1d4 to ecd29a1 Compare April 16, 2016 18:48
@gep13
Copy link
Member

gep13 commented Apr 16, 2016

@RichiCoder1 Just been looking through this, and it looks good to me! I am loving the amount of code that we can now remove 👍

I have corrected a few Code Analysis, InspectCode errors, etc, but there are still some left. They are regarding the Grid.Row and Grid.Column values for parts of the XAML. Would you be able to correct these issues? The issues are:

image

Thanks! There is still an issue with the build that I will need to look into tomorrow, but once that and the InspectCode issues are corrected, we should be in a position to merge this into the develop branch! 😄

@gep13
Copy link
Member

gep13 commented Apr 16, 2016

@RichiCoder1 ok, I see what the issue with the build is, I will fix that up tomorrow morning. Cheers!

@gep13 gep13 force-pushed the feature/Chocolatey_Lib branch from 640d1cb to ebae4d1 Compare April 17, 2016 12:36
@gep13
Copy link
Member

gep13 commented Apr 18, 2016

Oh, that's weird! When running on AppVeyor, the errors that I am seeing locally are only warnings:

image

Not sure why they are reacting differently, as they should be using the same configuration file.

Anyway, if you are happy, I can merge this into the develop branch, and look to start a new release. Thoughts?

@RichiCoder1
Copy link
Contributor Author

I'd be ok with merging, but I don't want to release this until we've got a sufficient level of polish around things like progress messages and command execution dialogs.

@gep13 gep13 merged commit cac4284 into develop Apr 18, 2016
@gep13 gep13 deleted the feature/Chocolatey_Lib branch April 18, 2016 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants