Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#990 #989) Update to latest chocolatey bits #991

Merged
merged 3 commits into from
Mar 20, 2023
Merged

(#990 #989) Update to latest chocolatey bits #991

merged 3 commits into from
Mar 20, 2023

Conversation

gep13
Copy link
Member

@gep13 gep13 commented Mar 20, 2023 •
edited
Loading

Description Of Changes

  • Remove usage of side by side related properties that have been removed upstream
  • Switch to new default for choco list

Motivation and Context

Removing deprecated features.

Testing

  1. Compiled the solution
  2. Opened Chocolatey GUI
  3. Checked to make sure installed packages are shown correctly
  4. Checked to make sure that remote packages are returned from remote feed

Operating Systems Testing

Win10

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

Fixes #990 and #989

gep13 added 2 commits March 20, 2023 09:56
@gep13
(chocolatey#990) Fix usage of ListCommand
e45f44e 
WIthout this change in place, the search for packages results in doing
a choco list command, which now only returns locally installed
packages.  Instead, we need to force usage of choco search, to ensure
that the remote repository is queried.
@gep13
(chocolatey#989) Remove usage of side by side
f7b7ecf 
With the upstream change in Chocolatey CLI to remove the usage of side
by side installations, we need to do the same thing within Chocolatey
GUI to prevent errors from happening.

This commit removes the usage of the properties that have been removed
from Chocolatey CLI, as well as changes the GUI to not include the
setting of these properties.
@gep13 gep13 requested a review from AdmiringWorm March 20, 2023 10:02
@gep13 gep13 linked an issue Mar 20, 2023 that may be closed by this pull request
Remove side-by-side installs #989
Closed
vexx32
vexx32 approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, seems like everything is working normally. Nice work!

@vexx32 vexx32 merged commit 9fbe0d0 into chocolatey:develop Mar 20, 2023
@gep13 gep13 deleted the update-to-latest-chocolatey-bits branch March 20, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vexx32 vexx32 vexx32 approved these changes

@AdmiringWorm AdmiringWorm Awaiting requested review from AdmiringWorm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure correct usage of ListCommand after upstream changes in Chocolatey CLI Remove side-by-side installs
2 participants
@gep13 @vexx32