[pull] dev from NuGet:dev

.editorconfig

@@ -13,6 +13,9 @@ charset = utf-8
 trim_trailing_whitespace = true
 insert_final_newline = true
 
+# Spell checker configuration
+spelling_exclusion_path = spelling.dic
+
 ; Code files
 [*.{cs}]
 indent_size = 4
@@ -139,3 +142,145 @@ dotnet_naming_symbols.private_field_symbols.applicable_accessibilities = private
 dotnet_naming_rule.private_field_rule.severity = warning
 dotnet_naming_rule.private_field_rule.symbols  = private_field_symbols
 dotnet_naming_rule.private_field_rule.style = private_member_style
+
+; Diagnostics rule: Don't leave unnecessary suppressions
+dotnet_diagnostic.IDE0076.severity = warning
+dotnet_diagnostic.IDE0005.severity = warning
+
+dotnet_diagnostic.VSTHRD200.severity = none
+
+# NuGet Code Analysis Rules
+# Code files under src/ folder
+[src/**/*.cs]
+dotnet_diagnostic.CA1000.severity = none
+dotnet_diagnostic.CA1001.severity = warning
+dotnet_diagnostic.CA1012.severity = warning
+dotnet_diagnostic.CA1016.severity = none
+dotnet_diagnostic.CA1018.severity = none
+dotnet_diagnostic.CA1028.severity = none
+dotnet_diagnostic.CA1030.severity = none
+dotnet_diagnostic.CA1031.severity = warning
+dotnet_diagnostic.CA1032.severity = none
+dotnet_diagnostic.CA1034.severity = none
+dotnet_diagnostic.CA1036.severity = none
+dotnet_diagnostic.CA1040.severity = none
+dotnet_diagnostic.CA1041.severity = none
+dotnet_diagnostic.CA1043.severity = none
+dotnet_diagnostic.CA1044.severity = none
+dotnet_diagnostic.CA1055.severity = none
+dotnet_diagnostic.CA1058.severity = none
+dotnet_diagnostic.CA1061.severity = none
+dotnet_code_quality.CA1062.null_check_validation_methods = Assumes
+dotnet_diagnostic.CA1064.severity = none
+dotnet_diagnostic.CA1065.severity = none
+dotnet_diagnostic.CA1066.severity = none
+dotnet_diagnostic.CA1068.severity = none
+dotnet_diagnostic.CA1200.severity = none
+dotnet_diagnostic.CA1303.severity = warning
+dotnet_diagnostic.CA1305.severity = warning
+dotnet_diagnostic.CA1401.severity = none
+dotnet_diagnostic.CA1501.severity = warning
+dotnet_diagnostic.CA1505.severity = warning
+dotnet_diagnostic.CA1707.severity = none
+dotnet_diagnostic.CA1710.severity = none
+dotnet_diagnostic.CA1712.severity = none
+dotnet_diagnostic.CA1714.severity = none
+dotnet_diagnostic.CA1715.severity = none
+dotnet_diagnostic.CA1716.severity = none
+dotnet_diagnostic.CA1717.severity = none
+dotnet_diagnostic.CA1720.severity = none
+dotnet_diagnostic.CA1721.severity = none
+dotnet_diagnostic.CA1724.severity = none
+dotnet_diagnostic.CA1801.severity = suggestion
+dotnet_diagnostic.CA1810.severity = none
+dotnet_diagnostic.CA1812.severity = none
+dotnet_diagnostic.CA1820.severity = none
+dotnet_diagnostic.CA1821.severity = warning
+dotnet_diagnostic.CA1822.severity = warning
+dotnet_diagnostic.CA1824.severity = none
+dotnet_diagnostic.CA1825.severity = warning
+dotnet_diagnostic.CA1826.severity = none
+dotnet_diagnostic.CA1828.severity = none
+dotnet_diagnostic.CA1829.severity = none
+dotnet_diagnostic.CA2002.severity = none
+dotnet_diagnostic.CA2007.severity = none
+dotnet_diagnostic.CA2008.severity = none
+dotnet_diagnostic.CA2009.severity = none
+dotnet_diagnostic.CA2010.severity = none
+dotnet_diagnostic.CA2016.severity = warning
+dotnet_diagnostic.CA2100.severity = none
+dotnet_diagnostic.CA2101.severity = none
+dotnet_diagnostic.CA2119.severity = none
+dotnet_diagnostic.CA2207.severity = none
+dotnet_diagnostic.CA2213.severity = warning
+dotnet_diagnostic.CA2214.severity = none
+dotnet_diagnostic.CA2216.severity = none
+dotnet_diagnostic.CA2219.severity = none
+dotnet_diagnostic.CA2226.severity = none
+dotnet_diagnostic.CA2229.severity = none
+dotnet_diagnostic.CA2231.severity = warning
+dotnet_diagnostic.CA2234.severity = none
+dotnet_diagnostic.CA2235.severity = none
+dotnet_diagnostic.CA2241.severity = none
+dotnet_diagnostic.CA2242.severity = none
+dotnet_diagnostic.CA2243.severity = none
+dotnet_diagnostic.CA2244.severity = none
+dotnet_diagnostic.CA2245.severity = none
+dotnet_diagnostic.CA2246.severity = none
+dotnet_diagnostic.CA2301.severity = warning
+dotnet_diagnostic.CA2302.severity = warning
+dotnet_diagnostic.CA2305.severity = warning
+dotnet_diagnostic.CA2311.severity = warning
+dotnet_diagnostic.CA2312.severity = warning
+dotnet_diagnostic.CA2315.severity = warning
+dotnet_diagnostic.CA2321.severity = warning
+dotnet_diagnostic.CA2322.severity = warning
+dotnet_diagnostic.CA3001.severity = warning
+dotnet_diagnostic.CA3061.severity = warning
+dotnet_diagnostic.CA3076.severity = warning
+dotnet_diagnostic.CA3077.severity = warning
+dotnet_diagnostic.CA3147.severity = warning
+dotnet_diagnostic.CA5351.severity = warning
+dotnet_diagnostic.CA5358.severity = warning
+dotnet_diagnostic.CA5359.severity = warning
+dotnet_diagnostic.CA5360.severity = none
+dotnet_diagnostic.CA5363.severity = none
+dotnet_diagnostic.CA5365.severity = none
+dotnet_diagnostic.CA5366.severity = none
+dotnet_diagnostic.CA5368.severity = none
+dotnet_diagnostic.CA5369.severity = none
+dotnet_diagnostic.CA5370.severity = none
+dotnet_diagnostic.CA5371.severity = none
+dotnet_diagnostic.CA5372.severity = none
+dotnet_diagnostic.CA5373.severity = none
+dotnet_diagnostic.CA5374.severity = none
+dotnet_diagnostic.CA5376.severity = none
+dotnet_diagnostic.CA5377.severity = none
+dotnet_diagnostic.CA5379.severity = none
+dotnet_diagnostic.CA5380.severity = none
+dotnet_diagnostic.CA5381.severity = none
+dotnet_diagnostic.CA5384.severity = none
+dotnet_diagnostic.CA5385.severity = none
+dotnet_diagnostic.CA5386.severity = warning
+dotnet_diagnostic.CA5397.severity = none
+dotnet_diagnostic.CA9999.severity = none
+dotnet_diagnostic.VSTHRD103.severity = silent
+dotnet_diagnostic.VSTHRD105.severity = silent
+dotnet_diagnostic.IDE0055.severity = warning
+
+# Code files under test/ folder
+[test/**/*.cs]
+dotnet_diagnostic.VSTHRD001.severity = none
+dotnet_diagnostic.VSTHRD002.severity = none
+dotnet_diagnostic.VSTHRD003.severity = none
+dotnet_diagnostic.VSTHRD010.severity = none
+dotnet_diagnostic.VSTHRD011.severity = none
+dotnet_diagnostic.VSTHRD012.severity = none
+dotnet_diagnostic.VSTHRD100.severity = none
+dotnet_diagnostic.VSTHRD101.severity = none
+dotnet_diagnostic.VSTHRD102.severity = none
+dotnet_diagnostic.VSTHRD103.severity = none
+dotnet_diagnostic.VSTHRD104.severity = none
+dotnet_diagnostic.VSTHRD105.severity = none
+dotnet_diagnostic.VSTHRD106.severity = none
+dotnet_diagnostic.IDE0055.severity = warning

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,31 +1,16 @@
 <!-- DO NOT MODIFY OR DELETE THIS TEMPLATE. IT IS USED IN AUTOMATION. -->
-## Bug
 
-<!-- Search https://github.com/NuGet/Home/issues, and create one if you can't find a suitable issue. -->
-<!-- Paste the full link, like https://github.com/nuget/home/issues/1000. GitHub will render is neatly. -->
-Fixes:
+# Bug
 
-Regression? Last working version:
+<!-- If this is an engineering change or test change only, you do not need an issue. -->
+<!-- Find or create an issue in NuGet/Home and paste the full url. -->
+<!-- At the maintainers discretion, multiple changes may apply to a single issue, but only when the PRs are all created within a short period of time. -->
+Fixes: 
 
 ## Description
-<!-- Add details about the fix. Include any information that would help the maintainer review this change effective. -->
 
 ## PR Checklist
 
-- [ ] PR has a meaningful title
-- [ ] PR has a linked issue.
-- [ ] Described changes
-
-- **Tests**
-  - [ ] Automated tests added
-  - **OR**
-  <!-- Describe why you haven't added automation. -->
-  - [ ] Test exception
-  - **OR**
-  - [ ] N/A <!-- Infrastructure, documentation etc. -->
-
-- **Documentation**
-  <!-- Please link the PR/issue if appropriate -->
-  - [ ] Documentation PR or issue filled
-  - **OR**
-  - [ ] N/A
+- [ ] Meaningful title, helpful description and a linked NuGet/Home issue
+- [ ] Added tests
+- [ ] Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.