Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#209) Disable Browser First Run Wizards #522

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

corbob
Copy link
Member

@corbob corbob commented Oct 1, 2022

Description Of Changes

Add a function to disable the first run wizards of Microsoft's browsers.

Motivation and Context

Invoke-WebRequest doesn't work properly until IE is configured. Edge has a long cumbersome first run wizard that many find undesirable.

Testing

  1. Copied the function into a PowerShell 5.1 window on a Windows 10 VM
  2. Ran the function in there
  3. Verified it worked as intended.

Change Types Made

  • Bug fix (non-breaking change)
  • Feature / Enhancement (non-breaking change)
  • Breaking change (fix or feature that could cause existing functionality to change)
  • PowerShell code changes.

Related Issue

Fixes #209

Change Checklist

  • Requires a change to the documentation
  • Documentation has been updated
  • Tests to cover my changes, have been added
  • All new and existing tests passed.
  • PowerShell v2 compatibility checked.

@corbob
Copy link
Member Author

corbob commented Oct 1, 2022

Opening this as draft to get it up. I noticed that both COMMITERS.md and CONTRIBUTING.md think they were modified, even though nothing but git thinks that 😂 . But it prompted me to ensure there weren't any differences with other Chocolatey ones, and noted a few things that I need to clean up about the function I've added here, so I'll get that done before marking this as ready.

@flcdrg
Copy link
Member

flcdrg commented Oct 2, 2022

This looks useful. As per your comment, do take a look at https://github.com/chocolatey/boxstarter/blob/develop/CONTRIBUTING.md#code-standards-and-style

@flcdrg flcdrg added the Improvement Issues that enhances existing functionality, or adds new features label Oct 2, 2022
@mwallner
Copy link
Member

👀

@corbob corbob force-pushed the 209-disable-browserfirstrun branch 2 times, most recently from 7aea2af to 3e35a32 Compare March 21, 2024 16:03
@corbob corbob marked this pull request as ready for review March 21, 2024 16:03
@corbob corbob force-pushed the 209-disable-browserfirstrun branch from 3e35a32 to 5398d23 Compare March 21, 2024 16:04
@flcdrg flcdrg force-pushed the 209-disable-browserfirstrun branch from 5398d23 to f71eeb1 Compare June 29, 2024 11:04
flcdrg
flcdrg previously approved these changes Jun 29, 2024
@flcdrg flcdrg added this to the 3.1.0 milestone Jun 29, 2024
@mwallner
Copy link
Member

mwallner commented Jul 1, 2024

NOTE: because of #565, it might be required to explicitly export new functions in the corresponding manifest (=> WinConfig.ps1) in order to be available during runtime... 🤔

@mwallner
Copy link
Member

mwallner commented Oct 3, 2024

@corbob - in order to move forward with this, could you export Disable-BoxstarterBrowserFirstRun in Boxstarter.WinConfig (CmdletsToExport)?

@corbob
Copy link
Member Author

corbob commented Oct 7, 2024

@mwallner, absolutely. I can likely get to that later this week or weekend.

Add function to disable browser first run wizards so that PowerShell
Invoke-WebRequest can work correctly, and so that Edge doesn't pester
the user to configure it.
@corbob
Copy link
Member Author

corbob commented Oct 17, 2024

@mwallner I got that updated (I'm on holidays this week, so technically still the weekend I previously mentioned 😏 )

@mwallner mwallner merged commit cd6f1f5 into chocolatey:develop Oct 18, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Issues that enhances existing functionality, or adds new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Implement disabling IE first run wizard
3 participants