Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate config / system state across everything #1746

Closed
gep13 opened this issue Mar 9, 2019 · 1 comment
Closed

Validate config / system state across everything #1746

gep13 opened this issue Mar 9, 2019 · 1 comment
Assignees
@gep13
Labels
5 - Released Improvement Priority_HIGH
Milestone
0.10.12

Comments

@gep13
Copy link
Member

gep13 commented Mar 9, 2019

In addition to the ability for individual commands to validate that everything is correct before proceeding, for example here:

https://github.com/chocolatey/choco/blob/master/src/chocolatey/infrastructure.app/commands/ChocolateyInstallCommand.cs#L169-L201

with the install command, it should also be possible to validate at a higher level, and not tidied specifically to an individual command.

This would allow the opportunity to valid on things like:

  • system state, prior to execution
  • global Chocolatey configuration
  • anything else that is deemed necessary

This should be implemented in an extensible way, so that new validations can be easily added.
@gep13 gep13 mentioned this issue Mar 9, 2019
Closed
gep13 added a commit to gep13/choco that referenced this issue Mar 9, 2019
@gep13
(chocolateyGH-1746) Add concept of global validation
2025f89 
This is implemented as a validation engine. Any new validations will
need to implement the IValidation interface, and be added to the
container in the ContainerBinding class.

When running with limited output, error messages will still be shown to
the user, but warning messages will be suppressed.

Initial validation is provided which errors if attempting to halt when
a reboot is detected, but when usage of package exit codes is turned
off.  This is an error, since without package exit codes turned on,
Chocolatey is not able to detect what actually happened when a package
is installed/upgraded/uninstalled.
gep13 added a commit to gep13/choco that referenced this issue Mar 11, 2019
@gep13
(chocolateyGH-1746) Add concept of global validation
9c0da09 
This is implemented as a validation engine. Any new validations will
need to implement the IValidation interface, and be added to the
container in the ContainerBinding class.

When running with limited output, error messages will still be shown to
the user, but warning messages will be suppressed.

Initial validation is provided which errors if attempting to halt when
a reboot is detected, but when usage of package exit codes is turned
off.  This is an error, since without package exit codes turned on,
Chocolatey is not able to detect what actually happened when a package
is installed/upgraded/uninstalled.
@ferventcoder ferventcoder changed the title Add ability to globally validate Chocolatey execution, and halt on error Global validation of config / system state Mar 11, 2019
@ferventcoder ferventcoder changed the title Global validation of config / system state Validate config / system state across everything Mar 11, 2019
@ferventcoder ferventcoder added this to the 0.10.12 milestone Mar 11, 2019
ferventcoder pushed a commit that referenced this issue Mar 11, 2019
@gep13 @ferventcoder
(GH-1746) Add concept of global validation
2a2305b 
This is implemented as a validation engine. Any new validations will
need to implement the IValidation interface, and be added to the
container in the ContainerBinding class.

When running with limited output, error messages will still be shown to
the user, but warning messages will be suppressed.

Initial validation is provided which errors if attempting to halt when
a reboot is detected, but when usage of package exit codes is turned
off.  This is an error, since without package exit codes turned on,
Chocolatey is not able to detect what actually happened when a package
is installed/upgraded/uninstalled.
ferventcoder added a commit that referenced this issue Mar 11, 2019
@ferventcoder
(GH-1746) update logging for validation
d8bb323 
Change the logging so each part can be determined what tripped up
something in an easier reading format.
ferventcoder added a commit that referenced this issue Mar 11, 2019
@ferventcoder
(GH-1746) Update XML comments / formatting
295606e 
Move some of the comments in the method up to remarks - add XML
comments for methods in PendingRebootService.
ferventcoder added a commit that referenced this issue Mar 11, 2019
@ferventcoder
Merge branch 'stable'
2c273d3 
* stable:
  (GH-1655) make virtual methods for outdated / package service
  (GH-1747) Fix: passing timeout switch of 0 is ignored
  (GH-1746) Update XML comments / formatting
  (GH-1746) update logging for validation
  (GH-1038) Stop operation on package reboot request
  (GH-1038) Stop execution if pending reboot
  (GH-1746) Add concept of global validation
  (maint) Corrected white space
@ferventcoder
Copy link
Member

This is completed and will be in 0.10.12.

@ferventcoder ferventcoder mentioned this issue Mar 14, 2019
Open
ferventcoder added a commit that referenced this issue Mar 15, 2019
@ferventcoder
(GH-1746) allow shutting off validation warnings
c84ca40 
If warnings tend to start to annoy someone, they may want to shut them
off, provide the ability to do so.
ferventcoder added a commit that referenced this issue Mar 15, 2019
@ferventcoder
Merge branch 'stable'
51dd325 
* stable:
  (doc) add exit codes to gen doc headings
  (doc) update generated docs
  (version) 0.10.12
  (doc) fix grammar
  (GH-1038) remove note on off recommendation
  (GH-1746) allow shutting off validation warnings
  (doc) update release notes for licensed extension
  (maint) whitespace
  (doc) update release notes
  (maint) formatting
  (GH-1758)(doc) provide exit code docs
  (doc) info - add usage / examples
  (doc) outdated - note ignore unfound
  (doc) scripting - point to scripting reference
  (doc) scripting - how to get exit code w/powershell
  (GH-1724) search - exit 2 on no results
  (GH-1758) control enhanced exit codes w/feature
  (doc) update release notes for 0.10.12 release
  (doc) update older release notes
@ferventcoder ferventcoder mentioned this issue Mar 17, 2019
Closed
@ferventcoder ferventcoder mentioned this issue Mar 31, 2020
Open
@ferventcoder ferventcoder changed the title Validate config / system state across everything config: Validate config / system state across everything Mar 31, 2020
@ferventcoder ferventcoder changed the title config: Validate config / system state across everything Validate config / system state across everything Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gep13 gep13

Labels
5 - Released Improvement Priority_HIGH
Projects
None yet
Milestone
0.10.12
Development

No branches or pull requests
2 participants
@ferventcoder @gep13