Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress verbose output to verbose - like with 7-zip #476

Closed
MikaelSmith opened this issue Nov 4, 2015 · 7 comments
Closed

Suppress verbose output to verbose - like with 7-zip #476

MikaelSmith opened this issue Nov 4, 2015 · 7 comments
Assignees
@ferventcoder
Labels
5 - Released Improvement
Milestone
0.9.10

Comments

@MikaelSmith
Copy link

For some packages, like mingw, listing all the files extracted is overwhelming. The log in AppVeyor is one instance.

Showing all the 7-Zip output is a recent change. It would be nice to have a way to suppress that output.
@ferventcoder
Copy link
Member

@MikaelSmith so if they come on with --verbose (aka -v), would you consider turning that off?

@ferventcoder
Copy link
Member

I would expect to see that in a verbose / debug log, but definitely not during normal operation.

@MikaelSmith
Copy link
Author

Yeah, I wasn't using verbose output (that I know of) when I tried it out with a recent version of Chocolatey.

@ferventcoder
Copy link
Member

Should be pretty easy to add. Right now it is letting it use the window, a recent change that fixed other things like powershell interaction #219

@ferventcoder ferventcoder added this to the 0.9.10 milestone Nov 5, 2015
@ferventcoder ferventcoder changed the title Suppress verbose 7-Zip output Suppress verbose output to verbose - like with 7-zip Jan 21, 2016
@ferventcoder ferventcoder self-assigned this Jan 21, 2016
ferventcoder added a commit that referenced this issue Jan 21, 2016
@ferventcoder
(GH-476) Verbose log file operations / checksum
381a492 
Any file system operation is probably better served as a verbose log as
it could be quite a bit of information being passed around.

For checksumming files, it is definitely a verbose set of information -
definitely not something we want to overload users with unless they opt
into seeing the information.
ferventcoder added a commit that referenced this issue Jan 24, 2016
@ferventcoder
Merge branch 'stable'
f9e0420 
* stable:
  (GH-332) Fixup example
  (GH-562) Download Cache is sha512
  (doc) updating the submitting issues section
  (maint) move readme template to top level
  (GH-476) Verbose log file operations / checksum

# Conflicts:
#	CONTRIBUTING.md
@ferventcoder ferventcoder mentioned this issue Feb 8, 2016
Closed
@ferventcoder
Copy link
Member

This was completed with #616.

ferventcoder pushed a commit that referenced this issue Feb 11, 2016
@Erlkoenig90 @ferventcoder
(GH-616) Deterministicly capture unzipped/extracted files
bde0941 
Sometimes, Install-ChocolateyZipPackage and Get-ChocolateyUnzip capture
files that don't belong to the package, record them in the
<packagename>Install.zip.txt file, and cause them to be removed upon
uninstallation by UnInstall-ChocolateyZipPackage. Instead use 7z's
standard output to determine which files belong to the package.
This also avoids scanning possibly large directory trees.

This also resolves GH-476 by suppressing 7z's output as verbose.
@ezyang
Copy link

ezyang commented Apr 6, 2016

It's too bad Appveyor's choco doesn't have this fix yet!

@ferventcoder ferventcoder mentioned this issue Apr 14, 2016
Closed
@chrisdembia
Copy link

I also am anticipating when this fix is propagated to AppVeyor. As far as I can, the fix hasn't been put in a released version of chocolately yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Improvement
Projects
None yet
Milestone
0.9.10
Development

No branches or pull requests
5 participants
@ezyang @ferventcoder @chrisdembia @gep13 @MikaelSmith