Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Successful installer exit codes not recognized by choco should return 0 #821

Closed
ferventcoder opened this issue Jun 21, 2016 · 1 comment
Closed

Successful installer exit codes not recognized by choco should return 0 #821

ferventcoder opened this issue Jun 21, 2016 · 1 comment
Assignees
@ferventcoder
Labels
5 - Released Bug Priority_HIGH
Milestone
0.9.10.3

Comments

@ferventcoder
Copy link
Member

ferventcoder commented Jun 21, 2016 •
edited
Loading

https://chocolatey.org/packages/qbittorrent#comment-2743141882

Discussion at https://gitter.im/chocolatey/choco?at=57699b590ede04dc49036f43

Related to #827
@ferventcoder ferventcoder added this to the 0.9.10.3 milestone Jun 21, 2016
@ferventcoder ferventcoder self-assigned this Jun 21, 2016
ferventcoder added a commit that referenced this issue Jun 23, 2016
@ferventcoder
(GH-821) ValidExitCodes not recognized return 0
35585c3 
If a valid exit code specified is not recognized as one of choco's
valid exit codes, provide a warning and set the exit code to 0.
ferventcoder added a commit that referenced this issue Jun 23, 2016
@ferventcoder
Merge branch 'stable'
40f3066 
* stable:
  (GH-826) SYSTEM user always uses machine TEMP
  (GH-808) Allow silent args as array
  (GH-821) ValidExitCodes not recognized return 0
  (GH-818) Allow disk to catch up - sleep
  (GH-822) Provide pending override and file wait
  (GH-818) Wait for processes to exit + 2 seconds
  (maint) formatting
  (GH-819) Fix - NotSilent install failure binding
  (GH-775) remove 7za
  (GH-775) Use 7z instead of 7za
@mwrock
Copy link
Member

mwrock commented Jun 23, 2016

also see chef/chef#5030 (comment)

@mwrock mwrock mentioned this issue Jun 23, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Bug Priority_HIGH
Projects
None yet
Milestone
0.9.10.3
Development

No branches or pull requests
3 participants
@ferventcoder @mwrock @gep13