(GH-132) List command #225
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| config.Quiet = true; | ||
| config.PackageNames = list_run(config).Select(p => p.Name).@join(ApplicationParameters.PackageNamesSeparator); |
There was a problem hiding this comment.
Don't leave my config set to quiet.
…o it works the way others do...
Move test into the PackageService so it happens during execution regardless of how it's called. Also did a minor refactor of line 431/436 to make the intent more readable.
|
@Jaykul @ferventcoder Is there anything that needs to happen for these to be unblocked? Really would like to incorporate these for ChocoGUI. I can take over work if necessary. |
|
I think I just need to take a look here and pull this in. |
| using services; | ||
|
|
||
| [CommandFor(CommandNameType.list)] | ||
| [CommandFor(CommandNameType.search)] | ||
| public sealed class ChocolateyListCommand : ICommand | ||
| public sealed class ChocolateyListCommand : IListCommand<PackageResult> |
There was a problem hiding this comment.
@Jaykul I don't see IListCommand<T> at all.
There was a problem hiding this comment.
I ended up reimplementing it, but didn't constrain T as I am unsure how you would have constrained it.
There was a problem hiding this comment.
Found that it was already in master only.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of changes fixes the various incarnations of the LIST command so that they return ... lists :-)
It depends on #224
Closes #132
Closes #223