(#508) Fix unit tests for new dependency handling #2917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The underlying framework NuGet.Client has changed how it resolves dependencies. Because of this we no longer have information about the dependencies that will be installed until everything has completed its run successfully. As such, if a failure happens during the dependency handling we only show the amount of total packages that was passed into the executable, instead of the old handling that also included the dependencies. For successful runs, even the dependencies will be listed as the amount of total packages.
|
The failing builds on this PR are due to the fact that we haven't (yet) publishing the Chocolatey.NuGet.* packages to NuGet.org, and are only available internally. These packages will be pushed in due course. |
|
@AdmiringWorm thanks for getting this fixed up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
The underlying framework NuGet.Client has changed how it
resolves dependencies. Because of this we no longer have
information about the dependencies that will be installed
until everything has completed its run successfully.
As such, if a failure happens during the dependency handling
we only show the amount of total packages that was passed
into the executable, instead of the old handling that also included
the dependencies.
For successful runs, even the dependencies will be listed as
the amount of total packages.
Motivation and Context
To get a working build for Chocolatey CLI.
Testing
.\build.ps1 --testExecutionType=all --shouldRunOpenCover=falseOperating Systems Testing
Change Types Made
Change Checklist
Related Issue
Related to #508