(#508) Attempt to resolve relative paths for sources

[TheCakeIsNaOH]

Description Of Changes

When setting up NuGet sources, if NuGet is unable to parse the path, this tries to resolve relative paths to absolute, and then retries setting up the NuGet source. If the path is unable to be resolved, then this ignores the error and lets NuGet handle the resulting invalid source.

This path resolution requires the filesystem to be passed in. This means that various method signatures change to allow access to the filesystem.

Motivation and Context

When using NuGet.Core, then relative paths were able to be resolved. But now with NuGet.Client, relative paths are resolved by clients, not by libraries, which is why this change has to be made. NuGet/NuGet.Client#3783

Testing

• Add wget .nupkg to C:\packages
• Open PowerShell at C:\
• Run choco.exe from this PR with .\choco.exe info wget --source="C:\packages"
• Run choco.exe from this PR with .\choco.exe info wget --source="packages"
• Change directory to C:\packages
• Run choco.exe from this PR with .\choco.exe info wget --source="."
• Validate that all of these output the wget info
• Rerun these commands, but with install (with -n -f) instead of info, and validate that the package installs each time.

Operating Systems Testing

• Windows 10 22H2

Change Types Made

• Bug fix (non-breaking change).
• Feature / Enhancement (non-breaking change).
• Breaking change (fix or feature that could cause existing functionality to change).
• Documentation changes.
• PowerShell code changes.

Change Checklist

• Requires a change to the documentation.
• Documentation has been updated.
• Tests to cover my changes, have been added.
• All new and existing tests passed?
• PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

Part of #508

[TheCakeIsNaOH]

choco/src/chocolatey.tests.integration/scenarios/InfoScenarios.cs

Lines 89 to 97 in 0379cdf

	[Fact]
	public void should_log_package_information()
	{
	var lastWriteDate = File.GetLastWriteTimeUtc(Path.Combine("PackageOutput", "installpackage.1.0.0" + NuGetConstants.PackageExtension))
	.ToShortDateString();
	MockLogger.Messages.Keys.ShouldContain(LogLevel.Info.to_string());
	MockLogger.Messages[LogLevel.Info.to_string()].ShouldContain(" Title: installpackage | Published: {0}\r\n Number of Downloads: n/a | Downloads for this version: n/a\r\n Package url\r\n Chocolatey Package Source: n/a\r\n Tags: installpackage admin\r\n Software Site: n/a\r\n Software License: n/a\r\n Summary: __REPLACE__\r\n Description: __REPLACE__\r\n".format_with(lastWriteDate));
	}

This test is failing, and I'm not quite sure why. Comparing the actual output vs the expected output, they appear to be the same.

[choco-bot]

Task linked: PROJ-426 Relative file path sources does not resolve correctly

[TheCakeIsNaOH]

I've tweaked the info output to make it the same as it was with NuGet.Core, so as to make the integration test pass.

[gep13]

LGTM!

[gep13]

@TheCakeIsNaOH the unit tests seem to be failing on Posix. Is this something that you can take a look at?

[TheCakeIsNaOH]

@gep13 I've updated this, and it is ready for review again.

[gep13]

LGTM!

[gep13]

@TheCakeIsNaOH thanks for getting this updated!