(#508) Fix --page and --page-size arguments #2949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 tasks
gep13
reviewed
Jan 6, 2023
This fixes --page and --page-size. Extra code is added to reduce the number of packages requested when the page argument is added.
This is code that no longer applicable for listing with NuGet.Client
|
@TheCakeIsNaOH thanks for getting this fixed up! I left one comment (which didn't prevent the merge, just something that needs to be actioned). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This fixes
--pageand--page-size. These arguments are inefficient because they require querying for all packages, and throw away everything but the page requested.Motivation and Context
When the list command was switched to use NuGet.Client libraries, support for
--pageand--page-sizewas removedTesting
.\choco.exe search google --source=https://community.chocolatey.org/api/v2, validate that about 248 packages are returned.\choco.exe search google --source=https://community.chocolatey.org/api/v2 --page=0, validate that 25 packages are returned.\choco.exe search google --source=https://community.chocolatey.org/api/v2 --page=2, validate that 25 packages are returned and that they are the different from--page=0.\choco.exe search google --source=https://community.chocolatey.org/api/v2 --page=0 --page-size=100, validate that 100 packages are returned.Operating Systems Testing
Change Types Made
Change Checklist
Related Issue
Part of #508
https://app.clickup.com/t/20540031/PROJ-449