Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#2738) Bring in version 2.0.0 of shimgen.exe #2976

Merged
merged 2 commits into from
Jan 17, 2023

Conversation

gep13
Copy link
Member

@gep13 gep13 commented Jan 16, 2023

Description Of Changes

This version of shimgen has been updated to target .NET Framework 4.8.

Motivation and Context

The is the same version that choco.exe now targets as well.

Testing

Ran local vagrant tests and everything appears to be working as it was before.

Operating Systems Testing

N/A

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

@gep13 gep13 requested a review from AdmiringWorm January 16, 2023 09:58
@corbob
Copy link
Member

corbob commented Jan 16, 2023

You'll probably want to update

@{ Name = 'shimgen' ; Version = '1.0.0' ; ChocolateyVersion = '1.0.0' ; IsSigned = $true }
to be version 2.0.0 for ShimGen and 2.0.0-alpha for Chocolatey. (this is the only tests that failed on the Test Kitchen run.

This version of checksum has been updated to target .NET Framework 4.8,
which is the same version that choco.exe now targets as well.
We are now using Shimgen 2.0.0, so we need to bump the check for this
version number.
@gep13
Copy link
Member Author

gep13 commented Jan 16, 2023

@corbob 👋🏻 @AdmiringWorm and I were actually just having that exact same conversation 😄

@gep13
Copy link
Member Author

gep13 commented Jan 17, 2023

Based on a conversation with @AdmiringWorm yesterday, and the internal test run completing, I am going to go ahead and merge this in.

@gep13 gep13 merged commit e4e439a into chocolatey:develop Jan 17, 2023
@gep13 gep13 deleted the update-shimgen branch January 17, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants