(GH-15)(GH-9) AutoInstaller Enhancements #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The specs are not passing yet, the tests have issues running as part of the suite but pass in isolation. :/ Plus I don't have all I want to test set up yet. |
|
Based on your description, I immediately thought of this setting in ReSharper:
But since you are using TestDriven.net, this won't help you, but perhaps there is a similar setting. |
|
I had fun with this recently on a Test Suite that I was writing. Things worked in isolation, but not when running all of them. Had to enable this setting to get it to work. |
|
Is there something for NUnit? |
Off the top of my head, I am not sure, I will do some digging, and let you know if I find anything. |
ferventcoder
force-pushed
the
ticket/master/autouninstaller
branch
2 times, most recently
from
f9e54b5 to
f3608bb
Compare
ferventcoder
force-pushed
the
ticket/master/autouninstaller
branch
4 times, most recently
from
81d0072 to
5d47b3d
Compare
Adding this will allow feature flagging new features.c
Require the feature and enabled to explicitly be set to true to allow a feature to be flagged as on.
Do not allow autouninstaller to run automatically. Since it is experimental, we want to lock it down and make folks explicitly opt into it.
Move the code for autouninstaller to its own service and remove the stipulation that powershell needed to have NOT run for the autouninstaller to run.
Remove nesting and return early.
Move checksumFiles and virusCheckFiles to feature flags and mark them appropriately.
Return whether a registry value exists.
If the registry key AND the install location still exist, run autouninstaller. Otherwise, skip and log the details.
Remove uninstall executable from uninstall arguments before cleaning it up for use by command executor.
- Move CommandExecutor away from static methods for the most part. Implement ICommandExecutor and set it up with container binding. Set AutoUninstallerService to use ICommandExecutor instead of static method calls. - Fix null reference error in Registry ctor - Log why when auto uninstaller is not run
Allows installer to report the InstallerType it implements.
Ensure uninstaller uses the right switches on uninstall based on HasQuietUninstall true or false.
ferventcoder
force-pushed
the
ticket/master/autouninstaller
branch
from
651723b to
ffc5e6e
Compare
ferventcoder
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature flag auto uninstaller.
Still in todo:
Closes #9
Closes #15