Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#2788) Remove side-by-side installs #3073

Merged
merged 1 commit into from
Mar 20, 2023
Merged

(#2788) Remove side-by-side installs #3073

merged 1 commit into from
Mar 20, 2023

Conversation

vexx32
Copy link
Member

@vexx32 vexx32 commented Mar 17, 2023

Description Of Changes

  • Remove side by side installs
  • Remove all the other stuff that was using / referencing it
  • Add a warning for the removed param so folks don't expect it to work and find it doesn't at all

Motivation and Context

Removing deprecated features.

Testing

  1. Run unit tests
  2. Run Invoke-Tests.ps1
  3. Do a install $something --allow-multiple run and note:
    • A warning is emitted saying the param isn't supported
    • The installed package is not placed in a versioned folder

Operating Systems Testing

Win11

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

Fixes #2788

@gep13 gep13 requested a review from corbob March 17, 2023 18:01
@vexx32 @gep13
(chocolatey#2788) Remove side-by-side installs
3ae03ea 
This functionality is deprecated and we're removing it for v2.0.
gep13
gep13 approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit 3bbb5b3 into chocolatey:develop Mar 20, 2023
@gep13
Copy link
Member

gep13 commented Mar 20, 2023

@vexx32 thank you for getting this fixed up!

@vexx32 vexx32 deleted the 2788-break-side-by-side branch March 20, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheCakeIsNaOH TheCakeIsNaOH TheCakeIsNaOH left review comments

@corbob corbob corbob requested changes

@pauby pauby pauby left review comments

@gep13 gep13 gep13 approved these changes

@AdmiringWorm AdmiringWorm Awaiting requested review from AdmiringWorm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove side-by-side installs
5 participants
@vexx32 @gep13 @pauby @corbob @TheCakeIsNaOH