Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#3526) Fix user agent test for licensed #3558

Merged

Conversation

vexx32
Copy link
Member

@vexx32 vexx32 commented Nov 8, 2024

Description Of Changes

  • Pick out a single user agent / process tree to check in tests

Motivation and Context

Licensed does queries in the background before / while normal commands are running, so we can end up with multiple user-agent debug lines.

Resolve this by just looking at the most recently-outputted user agent, as these should all look the same (and if not, the last one should be the one from the actual command run).

Testing

  1. Test in test kitchen w/ CLE

Operating Systems Testing

2019

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v3 compatibility checked?

Related Issue

#3526

Licensed does queries in the background before / while normal commands
are running, so we can end up with multiple user-agent debug lines.

Resolve this by just looking at the most recently-outputted user agent,
as these should all look the same (and if not, the last one should be
the one from the actual command run).
@vexx32 vexx32 requested a review from corbob November 8, 2024 20:46
@vexx32 vexx32 added this to the 2.4.0 milestone Nov 8, 2024
@vexx32 vexx32 added the NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product. label Nov 8, 2024
Copy link
Member

@corbob corbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@corbob corbob merged commit f3bced2 into chocolatey:release/2.4.0 Nov 8, 2024
5 checks passed
@vexx32 vexx32 added Tests Issues related to the tests (NUnit or Pester) 4 - Done 5 - Released labels Nov 12, 2024
@choco-bot
Copy link

🎉 This issue has been resolved in version 2.4.0 🎉

The release is available on:

Your GitReleaseManager bot 📦 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Done 5 - Released NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product. Tests Issues related to the tests (NUnit or Pester)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants