(GH-303) (Cont.) https://github.com/chocolatey/choco/pull/373/ #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preexisting Variables When adding a new element to PATH, Install-ChocolateyPath reads PATH (wh ich contains expanded variables), appends the new element, and then writes the value back to PATH. This results in PATH having its variables overwritten with its values. Instead of reading $env:PATH to find the current path, read it from the registry, which will retain the PATH's original variables.
… as per comments on: #373 (comment)
Renamed some variables and added comments.
|
Do you guys see any required changes on Am I missing other references to the |
|
Merged into stable at 4484e24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #303
Please refer to comments on #373
To help us finish the work here and also enable us to work on tickets depending on these changes, I've done all the changes as requested on the PR comments above.
I should have committed more often but I was kind of struggling with git yet 😛
If you guys have any questions please just ask.