Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#997) Update Terms Page to Use Astro #1010

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Conversation

st3phhays
Copy link
Member

Description Of Changes

The Terms page has been updated to use the correct Astro Components to render all the content needed. This was missed on the initial switchover to Astro.

Motivation and Context

This page is not working currently.

Testing

  • I have previewed these changes using the Docker Container or another method before submitting this pull request.
  1. Review the PR at (#407) Retain CollapseButton CSS choco-theme#409
  2. Pull down this PR.
  3. Run the site
  4. Go to http://localhost:5086/en-us/information/terms and notice there is now content. The TOC is on the page, and not in the right hand nav bar.

Change Types Made

  • Minor documentation fix (typos etc.).
  • Major documentation change (refactoring, reformatting or adding documentation to existing page).
  • New documentation page added.
  • The change I have made should have a video added, and I have raised an issue for this.

Change Checklist

  • Requires a change to menu structure (top or left-hand side)/
  • Menu structure has been updated

Related Issue

Relates to #997

The Terms page has been updated to use the correct
Astro Components to render all the content needed.
This was missed on the initial switchover to
Astro.
@st3phhays st3phhays self-assigned this Jun 13, 2024
@st3phhays st3phhays requested a review from gep13 June 13, 2024 01:15
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit c5f55ce into chocolatey:master Jun 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants