Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#345) Update documentation mention Get-BinRoot deprecation #401

Merged
merged 1 commit into from
Mar 21, 2022
Merged

(#345) Update documentation mention Get-BinRoot deprecation #401

merged 1 commit into from
Mar 21, 2022

Conversation

AdmiringWorm
Copy link
Member

Description Of Changes

Thpull request updates the mentions about Get-BinRoot to
say that this cmdlet is deprecated, and to instead use
the cmdlet Get-ToolsLocation instead.

Motivation and Context

This is necessary as the Get-BinRoot will be deprecated, and eventually removed in a future major release.

Testing

N/A

Change Types Made

  • Bug fix (non-breaking change)
  • Feature / Enhancement (non-breaking change)
  • Breaking change (fix or feature that could cause existing functionality to change)
  • PowerShell code changes.
  • Documentation.

Related Issue

Fixes #345

Change Checklist

  • Requires a change to the documentation
  • Documentation has been updated
  • Tests to cover my changes, have been added
  • All new and existing tests passed.
  • PowerShell v2 compatibility checked.

@AdmiringWorm AdmiringWorm self-assigned this Mar 3, 2022
@AdmiringWorm AdmiringWorm requested a review from pauby March 3, 2022 14:24
@AdmiringWorm AdmiringWorm mentioned this pull request Mar 3, 2022
Merged
9 tasks
@gep13 gep13 mentioned this pull request Mar 8, 2022
Closed
@gep13 gep13 force-pushed the 345-Explain-the-Get-BinRoot-upcoming-deprecation-in-the-wiki branch from d8eb5d7 to dc699d2 Compare March 10, 2022 08:51
@gep13 gep13 force-pushed the 345-Explain-the-Get-BinRoot-upcoming-deprecation-in-the-wiki branch from dc699d2 to 698aab5 Compare March 18, 2022 08:01
@AdmiringWorm @gep13
(chocolatey#345) Update documentation mention Get-BinRoot deprecation
4aa65fb 
This commit updates the mentions about Get-BinRoot to
say that this cmdlet is deprecated, and to instead use
the cmdlet Get-ToolsLocation instead.
@gep13 gep13 force-pushed the 345-Explain-the-Get-BinRoot-upcoming-deprecation-in-the-wiki branch from 698aab5 to 4aa65fb Compare March 21, 2022 13:03
gep13
gep13 approved these changes Mar 21, 2022
View reviewed changes
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit dba632b into chocolatey:master Mar 21, 2022
@gep13
Copy link
Member

gep13 commented Mar 21, 2022

@AdmiringWorm thanks for getting this updated!

choco-bot pushed a commit that referenced this pull request Mar 21, 2022
@web-flow
Continuous Integration Publish: dba632b
fc6273d 
Merge pull request #401 from AdmiringWorm/345-Explain-the-Get-BinRoot-upcoming-deprecation-in-the-wiki

(#345) Update documentation mention Get-BinRoot deprecation
@AdmiringWorm AdmiringWorm deleted the 345-Explain-the-Get-BinRoot-upcoming-deprecation-in-the-wiki branch June 7, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gep13 gep13 gep13 approved these changes

@pauby pauby Awaiting requested review from pauby

Assignees

@AdmiringWorm AdmiringWorm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explain the Get-BinRoot upcoming deprecation in the wiki
2 participants
@AdmiringWorm @gep13