Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#546) Clarify when runtime virus scanning is performed #623

Merged
merged 1 commit into from
Dec 16, 2022
Merged

(#546) Clarify when runtime virus scanning is performed #623

merged 1 commit into from
Dec 16, 2022

Conversation

vexx32
Copy link
Member

@vexx32 vexx32 commented Dec 16, 2022

Description Of Changes

  • Clarify that runtime virus scanning does not submit embedded binaries to the virus scanner and only operates on files downloaded for the installation.

Motivation and Context

See #546

Testing

  • I have previewed these changes using the Docker Container or another method before submitting this pull request.

Change Types Made

  • Minor documentation fix (typos etc.).
  • Major documentation change (refactoring, reformatting or adding documentation to existing page).
  • New documentation page added.
  • The change I have made should have a video added, and I have raised an issue for this.
    • Issue #

Change Checklist

  • Requires a change to menu structure (top or left hand side)/
  • Menu structure has been updated

Related Issue

Fixes #546

pauby
pauby requested changes Dec 16, 2022
View reviewed changes
input/en-us/choco/release-notes.md Outdated Show resolved Hide resolved
input/en-us/features/virus-check.md Outdated Show resolved Hide resolved
steviecoaster
steviecoaster approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@steviecoaster steviecoaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with latest changes

@pauby pauby merged commit 141255a into chocolatey:master Dec 16, 2022
@vexx32 vexx32 deleted the 546-virus-scanning branch December 16, 2022 16:43
choco-bot pushed a commit that referenced this pull request Dec 16, 2022
@web-flow
Continuous Integration Publish: 141255a
acd25a9 
Merge pull request #623 from vexx32/546-virus-scanning

(#546) Clarify when runtime virus scanning is performed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauby pauby pauby approved these changes

@steviecoaster steviecoaster steviecoaster approved these changes

@AdmiringWorm AdmiringWorm Awaiting requested review from AdmiringWorm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Better Wording that Virus Check Only Triggers on Non-Internalized Package Files
3 participants
@vexx32 @steviecoaster @pauby