Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving PropDiffN performance #663

Merged
merged 7 commits into from
Jan 22, 2020
Merged

Improving PropDiffN performance #663

merged 7 commits into from
Jan 22, 2020

Conversation

ArthurGodet
Copy link
Collaborator

Fixes # .

Changes proposed in this PR:

  • Improving PropDiffN performance by changing some data structure and slightly improving energy check

@chocoteam/core-developer

@ArthurGodet ArthurGodet requested a review from cprudhom January 21, 2020 08:10
@codecov-io
Copy link

codecov-io commented Jan 21, 2020

Codecov Report

Merging #663 into master will increase coverage by <.01%.
The diff coverage is 81.48%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #663      +/-   ##
============================================
+ Coverage     62.28%   62.29%   +<.01%     
- Complexity     9886     9896      +10     
============================================
  Files           634      634              
  Lines         40183    40199      +16     
  Branches       7686     7690       +4     
============================================
+ Hits          25027    25040      +13     
- Misses        12879    12882       +3     
  Partials       2277     2277
Impacted Files Coverage Δ Complexity Δ
...chocosolver/solver/variables/IVariableFactory.java 73.07% <100%> (+3.79%) 81 <5> (+5) ⬆️
...in/java/org/chocosolver/solver/variables/Task.java 80.64% <78.26%> (+0.64%) 21 <13> (+11) ⬆️
...java/org/chocosolver/solver/ParallelPortfolio.java 72.09% <0%> (-3.49%) 48% <0%> (-2%)
...cosolver/solver/constraints/ternary/PropMinBC.java 75.3% <0%> (-1.24%) 27% <0%> (-3%)
.../strategy/assignments/DecisionOperatorFactory.java 59.64% <0%> (+1.75%) 6% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 769beea...bbbdfb0. Read the comment docs.

Copy link
Member

@cprudhom cprudhom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remind me the gain observed ?

@ArthurGodet
Copy link
Collaborator Author

The gain on pure random instances was about 20% faster execution for the same number of nodes for the same search strategy (inputOrder).

@ArthurGodet ArthurGodet requested a review from cprudhom January 21, 2020 15:35
@cprudhom cprudhom merged commit 0bc56be into master Jan 22, 2020
@ArthurGodet ArthurGodet deleted the diff branch January 22, 2020 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants