Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cpru min max #665

Merged
merged 3 commits into from
Jan 22, 2020
Merged

Cpru min max #665

merged 3 commits into from
Jan 22, 2020

Conversation

cprudhom
Copy link
Member

Remove code from PropMaxBC and PropMinBC: the code was correct but this version is easiest to read and still correct.

@cprudhom cprudhom requested a review from ArthurGodet January 22, 2020 11:00
@codecov-io
Copy link

codecov-io commented Jan 22, 2020

Codecov Report

Merging #665 into master will increase coverage by <.01%.
The diff coverage is 95.55%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #665      +/-   ##
============================================
+ Coverage     62.25%   62.26%   +<.01%     
- Complexity     9861     9863       +2     
============================================
  Files           634      634              
  Lines         40101    40101              
  Branches       7658     7658              
============================================
+ Hits          24963    24967       +4     
+ Misses        12866    12865       -1     
+ Partials       2272     2269       -3
Impacted Files Coverage Δ Complexity Δ
...lver/solver/constraints/IIntConstraintFactory.java 73.22% <ø> (ø) 192 <0> (ø) ⬇️
...chocosolver/solver/constraints/nary/PropDiffN.java 81.94% <95.55%> (ø) 63 <42> (ø) ⬇️
...cosolver/solver/constraints/nary/cnf/PropTrue.java 62.5% <0%> (-12.5%) 3% <0%> (-1%)
...olver/constraints/nary/circuit/PropSubcircuit.java 86.58% <0%> (+2.43%) 27% <0%> (ø) ⬇️
...ts/nary/circuit/PropSubcircuitDominatorFilter.java 96.05% <0%> (+3.94%) 39% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f864f03...62d6f3e. Read the comment docs.

@ArthurGodet ArthurGodet merged commit 5763b72 into master Jan 22, 2020
@ArthurGodet ArthurGodet deleted the cpru-MinMax branch January 22, 2020 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants