Removed dynamic typing mechanism in CompoundState to fix pickling. #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had to transform the _standardize_system() method to an instance method rather than a class method to make the change.
|
Hey, FYI It looks like this change fixed my problem--thanks! |
|
Awesome, I'll merge this in then! The only thing failing is codeclimate that is outrageously accusing me of duplicating code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be ready for review as soon as tests pass.
I had to convert the
ThermodynamicState._standardize_system()method from class to instance method to make the change. All state classes are now tested for pickling.