Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Windows CI #568

Closed
wants to merge 5 commits into from
Closed

Disable Windows CI #568

wants to merge 5 commits into from

Conversation

mjw99
Copy link
Collaborator

@mjw99 mjw99 commented Apr 8, 2022

Description

Disable the Windows CI since it is failing (see #567). Aim to fix this on a branch and re-enable later on.

Todos

  • Implement feature / fix bug

Status

  • Ready to go

It is currently failing; see #567
@mjw99 mjw99 requested a review from ijpulidos April 8, 2022 14:17
@mjw99 mjw99 added this to the 0.21.3 milestone Apr 8, 2022
@mikemhenry
Copy link
Contributor

Good idea! Do you have a windows computer or VM to investigate why openmm might be having this issue? I'm wondering if we need to communicate upstream that there are issues with the windows build

@mikemhenry
Copy link
Contributor

Oh and I'm not sure if you have access to do this or not, but in the repo settings we need to remove the windows CI from the required checks.

@mjw99
Copy link
Collaborator Author

mjw99 commented Apr 8, 2022

Yes, I have a win10 image in my VirtualBox on my linux desktop; I can start to have a play there.

@ijpulidos
Copy link
Contributor

ijpulidos commented Apr 8, 2022

I remember trying this in a windows VM a few days ago and as far as I can tell the build py38hb8327ec_1 (for python 3.8) of openmm 7.7.0 is having issues.

On the other hand, the openmm 7.7.0 py39h6dc0912_1 (for py 3.9) doesn't show the issues. I think it doesn't hurt to communicate the issues with some builds upstream.

@ijpulidos
Copy link
Contributor

Wouldn't it be enough to mark the CI job as optional in this case? Since I think it helps the openmm folks that we are testing these configurations.

@mjw99
Copy link
Collaborator Author

mjw99 commented Apr 8, 2022

Wouldn't it be enough to mark the CI job as optional in this case? Since I think it helps the openmm folks that we are testing these configurations.

I think that would be a good idea; I did not know that was possible.

@ijpulidos
Copy link
Contributor

Thanks for bringing this up! This had to be done changing the branch settings for the repository. I have changed this already. Feel free to close.

@ijpulidos ijpulidos removed this from the 0.21.3 milestone Apr 8, 2022
@mjw99
Copy link
Collaborator Author

mjw99 commented Apr 8, 2022

Thanks for bringing this up! This had to be done changing the branch settings for the repository. I have changed this already. Feel free to close.

Awesome; thanks Iván. I think I was struggling with some of the CI.yml syntax.

@mjw99 mjw99 closed this Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants