Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issue #694 #704

Merged
merged 3 commits into from
Jun 5, 2023
Merged

Fixes issue #694 #704

merged 3 commits into from
Jun 5, 2023

Conversation

mikemhenry
Copy link
Contributor

@mikemhenry mikemhenry commented Jun 5, 2023 •
edited
Loading

Description

Fixes metadata for netcdf files.

Todos

  • Implement feature / fix bug
  • Add tests
  • Update documentation as needed
  • Update changelog to summarize changes in behavior, enhancements, and bugfixes implemented in this PR

Status

  • Ready to go

Changelog message

Update metadata for netcdf files to mention openmmtools version used to create the file

@mikemhenry mikemhenry marked this pull request as ready for review June 5, 2023 20:01
@mikemhenry
Copy link
Contributor Author

How does this look @IAlibay

@mikemhenry mikemhenry mentioned this pull request Jun 5, 2023
Closed
IAlibay
IAlibay reviewed Jun 5, 2023
View reviewed changes
Copy link
Contributor

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mikemhenry mikemhenry enabled auto-merge (squash) June 5, 2023 20:08
ijpulidos
ijpulidos approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@ijpulidos ijpulidos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@ijpulidos ijpulidos added this to the 0.22.2 milestone Jun 5, 2023
@ijpulidos ijpulidos disabled auto-merge June 5, 2023 22:35
@ijpulidos ijpulidos merged commit c491c3d into main Jun 5, 2023
@ijpulidos ijpulidos deleted the mikemhenry-patch-4 branch June 5, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IAlibay IAlibay IAlibay left review comments

@ijpulidos ijpulidos ijpulidos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mikemhenry @ijpulidos @IAlibay