Skip to content

Commit

Permalink
Replace package tf-nightly-gpu by tf-nightly (horovod#3826)
Browse files Browse the repository at this point in the history
Signed-off-by: Max H. Gerlach <git@maxgerlach.de>
  • Loading branch information
maxhgerlach authored Jan 26, 2023
1 parent 85619c6 commit abe639b
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 7 deletions.
4 changes: 2 additions & 2 deletions Dockerfile.test.gpu
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ RUN if [[ ${MPI_KIND} != "None" ]]; then \
# Install TensorFlow and Keras (releases).
# Pin scipy!=1.4.0: https://github.com/scipy/scipy/issues/11237
# Pin protobuf~=3.20 for tensorflow<2.6.5: https://github.com/tensorflow/tensorflow/issues/56077
RUN if [[ ${TENSORFLOW_PACKAGE} != "tf-nightly-gpu" ]]; then \
RUN if [[ ${TENSORFLOW_PACKAGE} != "tf-nightly" ]]; then \
PROTOBUF_PACKAGE=""; \
if [[ ${TENSORFLOW_PACKAGE} == tensorflow-gpu==1.15.* ]] || \
[[ ${TENSORFLOW_PACKAGE} == tensorflow-gpu==2.[012345].* ]]; then \
Expand Down Expand Up @@ -181,7 +181,7 @@ COPY . /horovod

# Install TensorFlow and Keras (nightly).
# Pin scipy!=1.4.0: https://github.com/scipy/scipy/issues/11237
RUN if [[ ${TENSORFLOW_PACKAGE} == "tf-nightly-gpu" ]]; then \
RUN if [[ ${TENSORFLOW_PACKAGE} == "tf-nightly" ]]; then \
pip install --no-cache-dir ${TENSORFLOW_PACKAGE}; \
if [[ ${KERAS_PACKAGE} != "None" ]]; then \
pip uninstall -y keras-nightly; \
Expand Down
3 changes: 1 addition & 2 deletions assert-package-versions.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@ do
if [ "$pattern" == "None" ]
then
continue
elif [[ "$pattern" == "tf-nightly" ]] ||
[[ "$pattern" == "tf-nightly-gpu" ]]
elif [[ "$pattern" == "tf-nightly" ]]
then
flag="-P"
pattern="$pattern==.*\\.dev20\\d{6}"
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ services:
CUDNN_VERSION: 8.6.0.163-1+cuda11.8
NCCL_VERSION_OVERRIDE: 2.11.4-1+cuda11.6
MPI_KIND: OpenMPI
TENSORFLOW_PACKAGE: tf-nightly-gpu
TENSORFLOW_PACKAGE: tf-nightly
KERAS_PACKAGE: None
PYTORCH_PACKAGE: torch-nightly-cu116
PYTORCH_LIGHTNING_PACKAGE: pytorch-lightning==1.5.9
Expand Down
4 changes: 2 additions & 2 deletions docker/horovod-nvtabular/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ RUN if [[ ${MPI_KIND} != "None" ]]; then \
# Install TensorFlow and Keras (releases).
# Pin scipy!=1.4.0: https://github.com/scipy/scipy/issues/11237
# Pin protobuf<4 for tensorflow: https://github.com/tensorflow/tensorflow/issues/56815
RUN if [[ ${TENSORFLOW_PACKAGE} != "tf-nightly-gpu" ]]; then \
RUN if [[ ${TENSORFLOW_PACKAGE} != "tf-nightly" ]]; then \
pip install --no-cache-dir ${TENSORFLOW_PACKAGE} "protobuf<3.20"; \
if [[ ${KERAS_PACKAGE} != "None" ]]; then \
pip uninstall -y keras; \
Expand Down Expand Up @@ -170,7 +170,7 @@ COPY . /horovod

# Install TensorFlow and Keras (nightly).
# Pin scipy!=1.4.0: https://github.com/scipy/scipy/issues/11237
RUN if [[ ${TENSORFLOW_PACKAGE} == "tf-nightly-gpu" ]]; then \
RUN if [[ ${TENSORFLOW_PACKAGE} == "tf-nightly" ]]; then \
pip install --no-cache-dir ${TENSORFLOW_PACKAGE}; \
if [[ ${KERAS_PACKAGE} != "None" ]]; then \
pip uninstall -y keras-nightly; \
Expand Down

0 comments on commit abe639b

Please sign in to comment.