Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid zero division to calculate rotation axis #14

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Avoid zero division to calculate rotation axis #14

merged 1 commit into from
Nov 18, 2022

Conversation

mmurooka
Copy link
Contributor

@mmurooka mmurooka commented Oct 7, 2022

Avoids zero division when rotation is identity. This solution is also taken by the following implementations.

@chongyi-zheng chongyi-zheng merged commit 4ab9b6e into chongyi-zheng:master Nov 18, 2022
@mmurooka mmurooka deleted the fix-zero-division branch November 19, 2022 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmurooka @chongyi-zheng