Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whitelist contents of component folder #643

Merged
merged 1 commit into from
Mar 13, 2018

Conversation

kareniel
Copy link
Member

@kareniel kareniel commented Mar 12, 2018

so we can npm install choojs/choo#choojs-component and get all the files :)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@yoshuawuyts yoshuawuyts merged commit 050649a into choojs-components Mar 13, 2018
@yoshuawuyts yoshuawuyts deleted the kareniel-patch-1 branch March 13, 2018 16:29
yoshuawuyts added a commit that referenced this pull request Mar 30, 2018

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* add components

* example: componentize header

* fix choo SSR

* example: componentize footer

* example: fix footer

* update component cache asserts

* componentize todos

* reorder example dir

* fix example tests

* fix dep check test

* Add garbage collection of unused components

* Apply args when calling identity

* update to new component preview

* update nanocomponent

* fix cache err name

* remove static methods from example

* restore app.emit() function

* public API tests

* offset component cache iteration by 2

* whitelist contents of component folder (#643)

* allow lru number arg

* fix lint typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants