Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix location missing on store init #695

Merged
merged 1 commit into from
Apr 2, 2019

Conversation

tornqvist
Copy link
Member

Location meta data was missing on store init during SSR, meaning href, query, route and params was missing from state when initializing stores.

This fixes that by running _matchRoute before initializing stores during SSR.

@tornqvist tornqvist merged commit 6a2f14c into choojs:master Apr 2, 2019
@tornqvist tornqvist deleted the store-init-location branch April 2, 2019 07:29
@tornqvist
Copy link
Member Author

v6.13.2 🎉

@tornqvist tornqvist mentioned this pull request Apr 2, 2019
tornqvist added a commit to tornqvist/choo that referenced this pull request Jun 8, 2019
* master:
  6.13.3
  Revert init order change
  Add browser tests (choojs#696)
  6.13.2
  Fix location missing on store init (choojs#695)
  Typo Fix in Readme (choojs#693)
  6.13.1
  Fix wrong this usage in nanohref integration (choojs#689)
  Some spelling & typo fixes in readme (choojs#688)
  Fix inspect script (choojs#654)
tornqvist added a commit to tornqvist/choo that referenced this pull request Jun 8, 2019
* master: (71 commits)
  6.13.3
  Revert init order change
  Add browser tests (choojs#696)
  6.13.2
  Fix location missing on store init (choojs#695)
  Typo Fix in Readme (choojs#693)
  6.13.1
  Fix wrong this usage in nanohref integration (choojs#689)
  Some spelling & typo fixes in readme (choojs#688)
  Fix inspect script (choojs#654)
  Add v6 tests (choojs#674)
  Remove references to bel (choojs#678)
  6.13.0
  Add hash option (choojs#667)
  Add documentation on components (choojs#673)
  Update README.md (choojs#669)
  6.12.1
  6.12.0
  typings: add app to app.use cb (choojs#665)
  update dependencies (choojs#663)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants