Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return early if click targets element outside of root node #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: return early if click targets element outside of root node
m90 committed Sep 4, 2019
commit bc633410f1b2c7f242d3d606c693b3dd1500129f
2 changes: 1 addition & 1 deletion index.js
Original file line number Diff line number Diff line change
@@ -16,7 +16,7 @@ function href (cb, root) {
window.addEventListener('click', function (e) {
if ((e.button && e.button !== 0) ||
e.ctrlKey || e.metaKey || e.altKey || e.shiftKey ||
e.defaultPrevented) return
e.defaultPrevented || !root.contains(e.target)) return

var anchor = (function traverse (node) {
if (!node || node === root) return