Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JR-630] 투표 상세 퍼블리싱 #128

Merged
merged 14 commits into from
Aug 31, 2023
Merged

Conversation

leejiho9898
Copy link
Member

📑 작업리스트

  • 투표 상세 퍼블리싱

📘 리뷰노트

  • 아무 기능 없는 퍼블리싱 상태 입니다

@vercel
Copy link

vercel bot commented Aug 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jurumarble ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 31, 2023 0:27am
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 31, 2023 0:27am

leejiho9898 and others added 11 commits August 29, 2023 23:21
* feat: navigation typography 추가

* feat: theme 추가 사항 반영

* feat: 디자인 수정사항 반영

* feat: 메인 페이지 인기있는 술 투표 퍼블리싱
* feat: navigation typography 추가

* feat: theme 추가 사항 반영

* feat: 디자인 수정사항 반영

* feat: 메인 페이지 인기있는 술 투표 퍼블리싱
}, [value]);

return [value, onToggle];
}
Copy link
Member

@Leejha Leejha Aug 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p3: ui 패키지 사용이 안되는거라 hooks는 hooks 패키지 사용하면 돼요!

@@ -3,6 +3,9 @@ import reset from "styled-reset";

const GlobalStyles = createGlobalStyle`
${reset}
body {
background-color: #f5f5f5;
}
Copy link
Member

@Leejha Leejha Aug 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p4: 기본 배경 색이 #fffff로 알고 있는데 기존 css에 영향가지 않을까요?

@leejiho9898 leejiho9898 merged commit ea6012c into develop Aug 31, 2023
1 check passed
@Leejha Leejha deleted the JR-630-publish-vote-detail branch August 31, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants