Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JR-679] 투표 홈 퍼블리싱 #134

Merged
merged 4 commits into from
Sep 6, 2023
Merged

Conversation

leejiho9898
Copy link
Member

📑 작업리스트

  • 투표 홈 애니메이션 구현
  • 페이지 퍼블리싱

📘 리뷰노트

  • TODO : 헤더 추가
    스크린샷 2023-09-05 오후 11 19 25

@vercel
Copy link

vercel bot commented Sep 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jurumarble ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2023 0:03am
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2023 0:03am

@@ -0,0 +1,75 @@
import React, { useRef, useState } from "react";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p5: React import 안해줘도 되지 않나요?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안해줘도 되져

@@ -65,6 +65,7 @@ const ButtonStyled = styled.button<ButtonStyledProps>`
padding: 0;
border: none;
cursor: pointer;
${theme.typography.button01}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p5: 기존에 Button 컴포넌트로 button01 넣어서 사용하고 있는 것들 지워주셨으면 더 좋았을 것 같아요

@leejiho9898 leejiho9898 force-pushed the JR-679-vote-home-publish branch from ec25869 to 4516249 Compare September 6, 2023 11:59
@leejiho9898 leejiho9898 merged commit 4a08000 into develop Sep 6, 2023
1 check passed
@leejiho9898 leejiho9898 deleted the JR-679-vote-home-publish branch September 6, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants