Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JR-749] 검색 페이지 리팩토링 #142

Merged
merged 2 commits into from
Sep 15, 2023
Merged

[JR-749] 검색 페이지 리팩토링 #142

merged 2 commits into from
Sep 15, 2023

Conversation

Leejha
Copy link
Member

@Leejha Leejha commented Sep 15, 2023 •
edited
Loading

📑 작업리스트

  • 검색 페이지를 각 탭 상태에 따라 관리
  • 페이지가 아닌, 컨테이너에서 로직을 관리하도록 변경

📘 리뷰노트

  • 추후 작업 예정
  • 아래와 같이 분리
<SeachProvider>
<SearchInputContainer />
<SearchVoteListContainer />
</SearchProvider>
  • 검색 상태를 관리하는 Context 만들기
    const {textInput} = useSearchContext()

@vercel
Copy link

vercel bot commented Sep 15, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jurumarble ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2023 4:38pm
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2023 4:38pm

@Leejha Leejha merged commit b43f0b2 into develop Sep 15, 2023
@Leejha Leejha deleted the JR-749-refactoring-search-page branch September 15, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leejiho9898 leejiho9898 Awaiting requested review from leejiho9898

Assignees

@Leejha Leejha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Leejha