Added borderColor #58
Conversation
When borderColor is set, a border with the given color is added to the image exterior, making it better to see the image ending when the baseColor and the image background are similar
|
Very good!! |
|
what a good guy. @vinicios-cervantes |
|
Hello @chooyan-eng, please review this PR |
|
@luciano-cervantes As I have few time to maintain this package, I've now started to check the PR. As long as reading your PR description and capture, it's nice idea! Wait for my checking your code. |
|
Still waiting... |
|
Complicated... |
|
Very complicated @luciano-cervantes |
|
The best review ever done... @vinicios-cervantes |
|
It has already completed a birthday @vinicios-cervantes . 🎉🎉 |
|
Happy birthday!! 🎂🥳🎉 |
| this.fixArea = false, | ||
| this.progressIndicator = const SizedBox.shrink(), | ||
| this.interactive = false, | ||
| }) : assert((initialSize ?? 1.0) <= 1.0, | ||
| 'initialSize must be less than 1.0, or null meaning not specified.'), | ||
| }) : assert((initialSize ?? 1.0) <= 1.0, 'initialSize must be less than 1.0, or null meaning not specified.'), |
There was a problem hiding this comment.
Can you format the code so that unrelated changes are not included in this PR?
| ? MediaQuery.of(context).size.height * _scale | ||
| : null, | ||
| fit: BoxFit.contain, | ||
| child: Flex( |
There was a problem hiding this comment.
Do we need Flex? It seems children always has only one child and Flex is not necessary.
| Positioned( | ||
| left: _imageRect.left, | ||
| top: _imageRect.top, | ||
| child: Image.memory( |
There was a problem hiding this comment.
I guess the border decoration should come here. Otherwise, as long as checking the example app, the border comes to the boundary of Crop, not the image.
| /// When [borderColor] is set, a border with the given color is added to the | ||
| /// image exterior, making it better to see the image ending when | ||
| /// the [baseColor] and the image background are similar | ||
| final Color? borderColor; |
There was a problem hiding this comment.
Why don't we accept Border, not only Color?
It enables users to decide other configurations, such as width.
When borderColor is set, a border with the given color is added to the image exterior, making it better to see the image ending when the baseColor and the image background are similar
demo:
