Skip to content
This repository has been archived by the owner on Jan 18, 2020. It is now read-only.

Remove group field from DataField and DataConcept #246

Closed
bruth opened this issue Oct 17, 2014 · 0 comments · Fixed by #248
Closed

Remove group field from DataField and DataConcept #246

bruth opened this issue Oct 17, 2014 · 0 comments · Fixed by #248

Comments

@bruth
Copy link
Contributor

bruth commented Oct 17, 2014

The group field was originally used for permissioning. That is data fields and concepts could be assigned to a group and only users who were part of those groups would be able to access those fields or concepts.

However, django-guardian is another mechanism for applying finer-grain permissions. The same strategy can be achieved above by assigning adding a permission to a group for the field/concept. Any users part of that group will have access to the fields/concepts.

Furthermore, in reviewing the code, the group field was never actually used in the published() manager method...

bruth added a commit that referenced this issue Oct 17, 2014
This was intended for permissioning, however it being superseded
by django-guardian.

Fix #246

Signed-off-by: Byron Ruth <b@devel.io>
bruth added a commit that referenced this issue Oct 17, 2014
This was intended for permissioning, however it being superseded
by django-guardian.

Fix #246

Signed-off-by: Byron Ruth <b@devel.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant