Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove noTitle dialect #1

Closed
wants to merge 1 commit into from
Closed

Remove noTitle dialect #1

wants to merge 1 commit into from

Conversation

bkeepers
Copy link
Member

This removes the noTitle dialect and syntax matching for title and artist. I think this was to support the chords over words syntax (which probalby should be a separate dialect, or separate grammar entirely) where the first two lines are freeform text and assumed to be title and artist.

@isaiahdahl did you have plans to use this?

@bkeepers bkeepers deleted the branch main April 17, 2024 18:27
@bkeepers bkeepers closed this Apr 17, 2024
@bkeepers bkeepers reopened this Apr 17, 2024
@bkeepers bkeepers changed the base branch from master to main April 17, 2024 18:29
@bkeepers bkeepers force-pushed the main branch 2 times, most recently from 20b03db to 4a38ae9 Compare April 17, 2024 18:30
It was not really being used anyway.
@isaiahdahl
Copy link
Contributor

It's been a minute, but I think the purpose was so you could have all the metadata managed separately from what was in the "text editor" and yet still share a language support that has requirements in another context for the first two lines to be freeform text.

I can remember going back and forth on whether or not to go down the path of separate language supports for chordpro and chords over words and opted for persuing one to support them all/both.

Is the purpose here to strip out support for chords over words from this library because it's named "chordpro" specifically? Or just not really knowing what the purpose of the noTitle was?

As of this moment I had planned to integrate the lang support lib in our private monorepo and then sync the changes for that package somewhere public, and that "somewhere public" could definitely be a fork of this and then we could be sharing work.

@bkeepers
Copy link
Member Author

Is the purpose here to strip out support for chords over words from this library because it's named "chordpro" specifically? Or just not really knowing what the purpose of the noTitle was?

I was just trying to wrap my head around the code so I can add new features, and I didn't see what the dialect was providing. I'm not sure it makes sense as a dialect on its own. I could see chords-over-words being a dialect that treats the first two lines as optional title/artist.

I personally don't plan to support chords over words as the stored format on ChordBook because it lacks the other metadata features. I currently convert to chordpro when pasting into the editor, and will probably add a more robust import feature at some point that converts from various formats.

This librarly could probably be simplified quite a bit if it didn't have to support chords over words, but I'll leave it for now and we can see how it all shakes out.

@bkeepers bkeepers closed this Apr 18, 2024
@bkeepers bkeepers deleted the remove-dialect branch April 18, 2024 12:27
@bkeepers
Copy link
Member Author

I could see chords-over-words being a dialect that treats the first two lines as optional title/artist.

Apparently I had started working toward simething similar in a previous life: chordbook:a27493a...chordbook:9583b2e

That commit adds pro and crd dialects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants