A try to make completion work better with default commands. #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oderwat
force-pushed
the
oderwat-better-completion
branch
from
7043528 to
f755f34
Compare
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are pleased to use 'fisk' for our tooling. There is just one problem for us: When you have a command set as Default(), the completion (we use bash) works in a way, that makes it a bit pointless because it considers only arguments following the default.
I tried different things to fix that. In the end came to the solution to calculate the options with and without the defaults and then, when they differ, return the combination of them. This way, it seems, we can have a meaningful output while still using default commands. From my tests, it also works with multiple default commands (see our newest msgcvt (a tool for
nats --translate).Revived from #39